minor cleanup for nuget build (#2)

Author: chrisstraw

src/OLT.Extensions.Configuration.RESTApi/ApiConfigBuilderExtensions.cs

@@ -60,8 +60,32 @@ public static ApiOptionsBuilder SetHeaderAcceptJson(this ApiOptionsBuilder build
     }
 
 
+    /// <summary>
+    /// Adds Path Segment to the end of the endpoint
+    /// </summary>
+    /// <remarks>
+    /// Base Endpoint = https://my.domain/api/configuration
+    /// <list type="table">
+    /// <item>
+    ///   <term>app1</term>
+    ///   <description>https://my.domain/api/configuration/app1</description>
+    /// </item>
+    /// <item>
+    ///   <term>foobar</term>
+    ///   <description>https://my.domain/api/configuration/foobar</description>
+    /// </item>
+    /// </list>
+    /// </remarks>
+    /// <param name="builder"></param>
+    /// <param name="segment"></param>
+    /// <returns></returns>
+    public static ApiOptionsBuilder AppendPathSegment(this ApiOptionsBuilder builder, string segment)
+    {
+        ArgumentNullException.ThrowIfNull(builder);
+        ArgumentNullException.ThrowIfNullOrEmpty(segment);
+        builder.Request.AppendPathSegment(segment);
+        return builder;
+    }
 
 
-  
-
 }

src/OLT.Extensions.Configuration.RESTApi/ApiOptionsBuilder.cs

@@ -3,7 +3,6 @@
 
 public class ApiOptionsBuilder
 {
-    private TimeSpan? _reloadAfter;
     private readonly string _endpoint;
     private readonly Flurl.Url _url;
 

src/OLT.Extensions.Configuration.RESTApi/ConfigurationBuilderExtensions.cs

@@ -15,9 +15,9 @@ public static class ConfigurationBuilderExtensions
     /// <param name="optional"></param>
     /// <returns>The <see cref="IConfigurationBuilder"/></returns>
     /// <exception cref="ArgumentNullException"></exception>
-    public static IConfigurationBuilder AddRestApiConfigProvider(this IConfigurationBuilder builder, string endpoint, bool optional)
+    public static IConfigurationBuilder AddRestApi(this IConfigurationBuilder builder, string endpoint, bool optional)
     {
-        return builder.AddRestApiConfigProvider(ConfigureSource(new ApiOptionsBuilder(endpoint), optional, null));
+        return builder.AddRestApi(ConfigureSource(new ApiOptionsBuilder(endpoint), optional, null));
     }
 
     /// <summary>
@@ -32,9 +32,9 @@ public static IConfigurationBuilder AddRestApiConfigProvider(this IConfiguration
     /// <param name="reloadAfter"></param>
     /// <returns>The <see cref="IConfigurationBuilder"/></returns>
     /// <exception cref="ArgumentNullException"></exception>
-    public static IConfigurationBuilder AddRestApiConfigProvider(this IConfigurationBuilder builder, string endpoint, bool optional, TimeSpan reloadAfter)
+    public static IConfigurationBuilder AddRestApi(this IConfigurationBuilder builder, string endpoint, bool optional, TimeSpan reloadAfter)
     {
-        return builder.AddRestApiConfigProvider(ConfigureSource(new ApiOptionsBuilder(endpoint), optional, reloadAfter));
+        return builder.AddRestApi(ConfigureSource(new ApiOptionsBuilder(endpoint), optional, reloadAfter));
     }
 
     /// <summary>
@@ -46,11 +46,11 @@ public static IConfigurationBuilder AddRestApiConfigProvider(this IConfiguration
     /// <param name="action"></param>
     /// <returns>The <see cref="IConfigurationBuilder"/></returns>
     /// <exception cref="ArgumentNullException"></exception>
-    public static IConfigurationBuilder AddRestApiConfigProvider(this IConfigurationBuilder builder, string endpoint, bool optional, Action<ApiOptionsBuilder> action)
+    public static IConfigurationBuilder AddRestApi(this IConfigurationBuilder builder, string endpoint, bool optional, Action<ApiOptionsBuilder> action)
     {
         var optionsBuilder = new ApiOptionsBuilder(endpoint);
         action(optionsBuilder);
-        return builder.AddRestApiConfigProvider(ConfigureSource(optionsBuilder, optional, null));
+        return builder.AddRestApi(ConfigureSource(optionsBuilder, optional, null));
     }
 
     /// <summary>
@@ -63,11 +63,11 @@ public static IConfigurationBuilder AddRestApiConfigProvider(this IConfiguration
     /// <param name="action"></param>
     /// <returns>The <see cref="IConfigurationBuilder"/></returns>
     /// <exception cref="ArgumentNullException"></exception>
-    public static IConfigurationBuilder AddRestApiConfigProvider(this IConfigurationBuilder builder, string endpoint, bool optional, TimeSpan reloadAfter, Action<ApiOptionsBuilder> action)
+    public static IConfigurationBuilder AddRestApi(this IConfigurationBuilder builder, string endpoint, bool optional, TimeSpan reloadAfter, Action<ApiOptionsBuilder> action)
     {
         var optionsBuilder = new ApiOptionsBuilder(endpoint);
         action(optionsBuilder);
-        return builder.AddRestApiConfigProvider(ConfigureSource(optionsBuilder, optional, reloadAfter));
+        return builder.AddRestApi(ConfigureSource(optionsBuilder, optional, reloadAfter));
     }
 
 
@@ -79,7 +79,7 @@ public static IConfigurationBuilder AddRestApiConfigProvider(this IConfiguration
     /// <param name="configureSource"></param>
     /// <returns>The <see cref="IConfigurationBuilder"/></returns>
     /// <exception cref="ArgumentNullException"></exception>
-    public static IConfigurationBuilder AddRestApiConfigProvider(this IConfigurationBuilder builder, Action<RestApiProviderConfigurationSource> configureSource)
+    public static IConfigurationBuilder AddRestApi(this IConfigurationBuilder builder, Action<RestApiProviderConfigurationSource> configureSource)
     {
         if (configureSource == null) throw new ArgumentNullException(nameof(configureSource));
         var source = new RestApiProviderConfigurationSource();        

src/OLT.Extensions.Configuration.RESTApi/DictionaryExtensions.cs

@@ -1,10 +1,10 @@
 namespace OLT.Extensions.Configuration.RESTApi;
 
-public static class DictionaryExtensions
+internal static class DictionaryExtensions
 {
     public static bool EquivalentTo<TKey, TValue>(this IDictionary<TKey, TValue> first, IDictionary<TKey, TValue> second) => EquivalentTo(first, second, null);
 
-    public static bool EquivalentTo<TKey, TValue>(this IDictionary<TKey, TValue> first, IDictionary<TKey, TValue> second, IEqualityComparer<TValue> valueComparer)
+    public static bool EquivalentTo<TKey, TValue>(this IDictionary<TKey, TValue> first, IDictionary<TKey, TValue> second, IEqualityComparer<TValue>? valueComparer)
     {
         if (first == second) return true;
         if (first == null || second == null) return false;

tests/OLT.Extensions.Configuration.RESTApi.Tests/ConfigurationsUnitTest.cs

@@ -19,7 +19,7 @@ public void BuildConfiguration_ShouldReturnConfigurationSource()
             var environment = configSection["Environment"] ?? string.Empty;
             var apiKey = configSection["ApiKey"] ?? string.Empty;
 
-            ConfigurationBuilderExtensions.AddRestApiConfigProvider(configBuilder, endpoint, true, options =>
+            ConfigurationBuilderExtensions.AddRestApi(configBuilder, endpoint, true, options =>
             {
                 options
                     .SetHeaderAcceptJson()