Remove public error properties of sniffs that don't need them (ref #2823)

Author: gsherwood

CHANGELOG.md

@@ -70,3 +70,24 @@ The file documents changes to the PHP_CodeSniffer project.
 - Removed JS-specific sniff `Squiz.WhiteSpace.PropertyLabelSpacing`
 - Removed the entire `Squiz.CSS` category, and all sniffs within
 - Removed the entire `MySource` standard, and all sniffs within
+- Removed `error` property of sniff `Generic.Strings.UnnecessaryStringConcat`
+    - This sniff now always produces errors
+    - To make this sniff produce warnings, include the following in a `ruleset.xml` file:
+        ```xml
+        <rule ref="Generic.Strings.UnnecessaryStringConcat">
+            <type>warning</type>
+        </rule>
+        ```
+- Removed `error` property of sniff `Generic.Formatting.MultipleStatementAlignment`
+    - This sniff now always produces warnings
+    - Also removes the `Generic.Formatting.MultipleStatementAlignment.IncorrectWarning` sniff message
+        - Now renamed to `Generic.Formatting.MultipleStatementAlignment.Incorrect`
+    - Also removes the `Generic.Formatting.MultipleStatementAlignment.NotSameWarning` sniff message
+        - Now renamed to `Generic.Formatting.MultipleStatementAlignment.NotSame`
+    - To make this sniff produce errors, include the following in a `ruleset.xml` file:
+        ```xml
+        <rule ref="Generic.Formatting.MultipleStatementAlignment">
+            <type>error</type>
+        </rule>
+        ```
+

src/Standards/Generic/Sniffs/Formatting/MultipleStatementAlignmentSniff.php

@@ -19,13 +19,6 @@
 class MultipleStatementAlignmentSniff implements Sniff
 {
 
-    /**
-     * If true, an error will be thrown; otherwise a warning.
-     *
-     * @var boolean
-     */
-    public $error = false;
-
     /**
      * The maximum amount of padding before the alignment is ignored.
      *
@@ -355,11 +348,7 @@ public function checkAlignment($phpcsFile, $stackPtr, $end=null)
                 $foundText,
             ];
 
-            if ($this->error === true) {
-                $fix = $phpcsFile->addFixableError($error, $assignment, $type, $errorData);
-            } else {
-                $fix = $phpcsFile->addFixableWarning($error, $assignment, $type.'Warning', $errorData);
-            }
+            $fix = $phpcsFile->addFixableWarning($error, $assignment, $type, $errorData);
 
             $errorGenerated = true;
 

src/Standards/Generic/Sniffs/Strings/UnnecessaryStringConcatSniff.php

@@ -16,13 +16,6 @@
 class UnnecessaryStringConcatSniff implements Sniff
 {
 
-    /**
-     * If true, an error will be thrown; otherwise a warning.
-     *
-     * @var boolean
-     */
-    public $error = true;
-
     /**
      * If true, strings concatenated over multiple lines are allowed.
      *
@@ -86,11 +79,7 @@ public function process(File $phpcsFile, $stackPtr)
                 }
 
                 $error = 'String concat is not required here; use a single string instead';
-                if ($this->error === true) {
-                    $phpcsFile->addError($error, $stackPtr, 'Found');
-                } else {
-                    $phpcsFile->addWarning($error, $stackPtr, 'Found');
-                }
+                $phpcsFile->addError($error, $stackPtr, 'Found');
             }//end if
         }//end if