Skip to content

Commit 74b8b7d

Browse files
committed
PrintProgress*Test: temporarily disable tests
... as they are incompatible with the STDOUT vs STDERR changes as made in PHPCS 4.0 in its current state.
1 parent 0de289b commit 74b8b7d

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

tests/Core/Runner/PrintProgressDotsTest.php

+6
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,12 @@ public static function dataProgressDotCbf()
196196
*/
197197
private function checkProgressDot($colors, $code, $sniffs, $expected, $enableFixer=false)
198198
{
199+
if (version_compare(Config::VERSION, '4.0', '>=') === true) {
200+
// This test is temporarily disabled on PHPCS 4.x as the stdOut/stdErr handling needs
201+
// a rewrite, as, as things are, it makes testing impossible.
202+
$this->markTestSkipped('This test is incompatible with PHPCS 4.0 (for now)');
203+
}
204+
199205
$this->expectOutputString($expected);
200206

201207
$config = new ConfigDouble(['-p']);

tests/Core/Runner/PrintProgressTest.php

+18
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,12 @@ public static function reset()
116116
*/
117117
public function testNoProgressIsShownWhenDisabled()
118118
{
119+
if (version_compare(Config::VERSION, '4.0', '>=') === true) {
120+
// This test is temporarily disabled on PHPCS 4.x as the stdOut/stdErr handling needs
121+
// a rewrite, as, as things are, it makes testing impossible.
122+
$this->markTestSkipped('This test is incompatible with PHPCS 4.0 (for now)');
123+
}
124+
119125
$this->expectOutputString('');
120126

121127
self::$config->showProgress = false;
@@ -134,6 +140,12 @@ public function testNoProgressIsShownWhenDisabled()
134140
*/
135141
public function testProgressDotSkippedFiles()
136142
{
143+
if (version_compare(Config::VERSION, '4.0', '>=') === true) {
144+
// This test is temporarily disabled on PHPCS 4.x as the stdOut/stdErr handling needs
145+
// a rewrite, as, as things are, it makes testing impossible.
146+
$this->markTestSkipped('This test is incompatible with PHPCS 4.0 (for now)');
147+
}
148+
137149
$nrOfFiles = 10;
138150
$this->expectOutputString('.S.S.S.S.S 10 / 10 (100%)'.PHP_EOL);
139151

@@ -162,6 +174,12 @@ public function testProgressDotSkippedFiles()
162174
*/
163175
public function testEndOfLineSummary($nrOfFiles, $expected)
164176
{
177+
if (version_compare(Config::VERSION, '4.0', '>=') === true) {
178+
// This test is temporarily disabled on PHPCS 4.x as the stdOut/stdErr handling needs
179+
// a rewrite, as, as things are, it makes testing impossible.
180+
$this->markTestSkipped('This test is incompatible with PHPCS 4.0 (for now)');
181+
}
182+
165183
$this->expectOutputString($expected);
166184

167185
for ($i = 1; $i <= $nrOfFiles; $i++) {

0 commit comments

Comments
 (0)