Merge pull request #895 from PHPCSStandards/feature/generic-deprecatedfunctions-minor-test-improvement

jrfnl · web-flow · commit c8288709fe9f · 2025-03-18T21:05:11.000+01:00
Generic/DeprecatedFunctions: add test which will work for PHP 8.0+
diff --git a/src/Standards/Generic/Tests/PHP/DeprecatedFunctionsUnitTest.inc b/src/Standards/Generic/Tests/PHP/DeprecatedFunctionsUnitTest.inc
@@ -2,3 +2,4 @@
 
 create_function(); // Deprecated PHP 7.2.
 mbsplit(); // Deprecated PHP 7.3.
+libxml_disable_entity_loader(); // Deprecated PHP 8.0.
diff --git a/src/Standards/Generic/Tests/PHP/DeprecatedFunctionsUnitTest.php b/src/Standards/Generic/Tests/PHP/DeprecatedFunctionsUnitTest.php
@@ -40,6 +40,10 @@ public function getErrorList()
             $errors[4] = 1;
         }
 
+        if (PHP_VERSION_ID >= 80000) {
+            $errors[5] = 1;
+        }
+
         return $errors;
 
     }//end getErrorList()

Original file line number	Diff line number	Diff line change
`@@ -2,3 +2,4 @@`
`2`	`2`
`3`	`3`	`create_function(); // Deprecated PHP 7.2.`
`4`	`4`	`mbsplit(); // Deprecated PHP 7.3.`
	`5`	`+libxml_disable_entity_loader(); // Deprecated PHP 8.0.`
Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,10 @@ public function getErrorList()`
`40`	`40`	`$errors[4] = 1;`
`41`	`41`	`}`
`42`	`42`
	`43`	`+ if (PHP_VERSION_ID >= 80000) {`
	`44`	`+ $errors[5] = 1;`
	`45`	`+ }`
	`46`	`+`
`43`	`47`	`return $errors;`
`44`	`48`
`45`	`49`	`}//end getErrorList()`