Update ReferenceHelper.php (#1873)

ivanstan · web-flow · commit 8721f795fc45 · 2021-03-01T12:33:35.000+01:00
* Update ReferenceHelper for Defined Names
diff --git a/src/PhpSpreadsheet/ReferenceHelper.php b/src/PhpSpreadsheet/ReferenceHelper.php
@@ -608,7 +608,7 @@ public function insertNewBefore($pBefore, $pNumCols, $pNumRows, Worksheet $pShee
         // Update workbook: define names
         if (count($pSheet->getParent()->getDefinedNames()) > 0) {
             foreach ($pSheet->getParent()->getDefinedNames() as $definedName) {
-                if ($definedName->getWorksheet()->getHashCode() === $pSheet->getHashCode()) {
+                if ($definedName->getWorksheet() !== null && $definedName->getWorksheet()->getHashCode() === $pSheet->getHashCode()) {
                     $definedName->setValue($this->updateCellReference($definedName->getValue(), $pBefore, $pNumCols, $pNumRows));
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -608,7 +608,7 @@ public function insertNewBefore($pBefore, $pNumCols, $pNumRows, Worksheet $pShee`
`608`	`608`	`// Update workbook: define names`
`609`	`609`	`if (count($pSheet->getParent()->getDefinedNames()) > 0) {`
`610`	`610`	`foreach ($pSheet->getParent()->getDefinedNames() as $definedName) {`
`611`		`- if ($definedName->getWorksheet()->getHashCode() === $pSheet->getHashCode()) {`
	`611`	`+ if ($definedName->getWorksheet() !== null && $definedName->getWorksheet()->getHashCode() === $pSheet->getHashCode()) {`
`612`	`612`	`$definedName->setValue($this->updateCellReference($definedName->getValue(), $pBefore, $pNumCols, $pNumRows));`
`613`	`613`	`}`
`614`	`614`	`}`