Skip to content

Commit d5c0610

Browse files
committed
Merge pull request #126 in SAT/pbmm2 from bugfix/TAK-390-remove-max-mem-check to develop
* commit '754ee9c39678abca80f52e17c70f7d07b8bb3a7e': Do not check for max memory
2 parents 0c0347b + 754ee9c commit d5c0610

File tree

4 files changed

+1
-24
lines changed

4 files changed

+1
-24
lines changed

meson.build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
project(
22
'pbmm2',
33
['c', 'cpp'],
4-
version : '1.2.0',
4+
version : '1.2.1',
55
default_options : [
66
'buildtype=release',
77
'warning_level=3',

src/AlignSettings.cpp

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -527,22 +527,6 @@ AlignSettings::AlignSettings(const PacBio::CLI_v2::Results& options)
527527
<< SortThreads << " threads for sorting, and " << maxMemSortFloat
528528
<< maxMemSortSuffix << " bytes RAM for sorting.";
529529

530-
auto pages = sysconf(_SC_PHYS_PAGES);
531-
auto page_size = sysconf(_SC_PAGE_SIZE);
532-
auto availableMemory = pages * page_size;
533-
534-
float availFloat;
535-
std::string availSuffix;
536-
MemoryToHumanReadable(availableMemory, &availFloat, &availSuffix);
537-
538-
if (maxMem > availableMemory) {
539-
std::ostringstream os;
540-
os << "Trying to allocate more memory for sorting (" << maxMemSortFloat
541-
<< maxMemSortSuffix << ") than system-wide available (" << availFloat << availSuffix
542-
<< ")";
543-
throw AbortException(os.str());
544-
}
545-
546530
BamIdx = BamIndex::_from_string(bamIdx.c_str());
547531

548532
if (noBai) {

tests/cram/baminput.t

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -360,10 +360,6 @@
360360
*Requested more threads for sorting* (glob)
361361
*Requested more threads for sorting* (glob)
362362

363-
$ $__PBTEST_PBMM2_EXE align $IN $REF $CRAMTMP/fail4.bam -j 1 -J 2 --sort -m 1000G 2>&1
364-
*Trying to allocate more memory for sorting* (glob)
365-
[1]
366-
367363
$ $__PBTEST_PBMM2_EXE align $IN $REF $CRAMTMP/sort_percentage_4.bam -j 4 --sort --log-level INFO 2>&1 | grep "threads for alignments"
368364
*Using 3 threads for alignments, 1 threads for sorting, and 768M bytes RAM for sorting.* (glob)
369365

tests/cram/misc.t

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,6 @@
7474
$ $__PBTEST_PBMM2_EXE align $IN $REF $CRAMTMP/fail.bam --zmw --hqregion 2>&1; rm -rf $CRAMTMP/fail.bam
7575
*Options --zmw, --hqregion and --median-filter are mutually exclusive.* (glob)
7676

77-
$ $__PBTEST_PBMM2_EXE align $IN $REF $CRAMTMP/fail.bam --sort -J 1 -m 1000G 2>&1; rm -rf $CRAMTMP/fail.bam
78-
*Trying to allocate more memory for sorting* (glob)
79-
8077
$ $__PBTEST_PBMM2_EXE align $IN $REF $CRAMTMP/fail.bam --sort -J 1 -m 1000P 2>&1; rm -rf $CRAMTMP/fail.bam
8178
*Unknown size multiplier P* (glob)
8279

0 commit comments

Comments
 (0)