Skip to content

Conversation

@pkuyym
Copy link
Contributor

@pkuyym pkuyym commented Nov 16, 2017

Resolves #9

@pkuyym pkuyym requested a review from kuke November 16, 2017 15:11
Copy link
Contributor

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

README.md Outdated
VoxForge Indian | 56.79 | 28.15
Baidu Internal Testset  |   47.73 |   8.92

For reproducing benchmark results on VoxForge data, we provide a script to generate VoxForge dialect manifest files. Please go to ```data/voxforge``` and execute ```sh run_data.sh``` to get VoxForge dialect manifest files. Notice that VoxForge data may keep updated and the generated manifest files may have difference from those we evaluated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we provide a script to generate VoxForge dialect manifest files -> we provide a script to download data and generate VoxForge dialect manifest files
may keep updated -> may keep updating
we evaluated -> we evaluated on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


# download data, generate manifests
PYTHONPATH=.:$PYTHONPATH python data/voxforge/voxforge.py \
--manifest_prefix='data/voxforge/manifest' \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that run the script in the same directory, cd ../.. > /dev/null and the prefix data/voxforge won't be necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkuyym pkuyym merged commit 45760eb into PaddlePaddle:develop Nov 20, 2017
Jackwaterveg pushed a commit to Jackwaterveg/DeepSpeech that referenced this pull request Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants