Skip to content

Commit 682ca64

Browse files
author
Zhang Ting
authored
approval for skip_check_grad_ci is required, test=develop (#21854)
1 parent 1032f93 commit 682ca64

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

tools/check_api_approvals.sh

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,22 @@ if [ "${NEW_OP_TEST_ADDED}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then
198198
fi
199199
fi
200200

201+
UNITTEST_FILE_CHANGED=`git diff --name-only --diff-filter=AM upstream/$BRANCH |grep -E "test_.*.\.py" || true`
202+
if [ "${UNITTEST_FILE_CHANGED}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then
203+
for TEST_FILE in ${UNITTEST_FILE_CHANGED};
204+
do
205+
HAS_SKIP_CHECK_GRAD_CI=`git diff -U0 upstream/$BRANCH ${PADDLE_ROOT}/${TEST_FILE} |grep "@skip_check_grad_ci" || true`
206+
if [ "${HAS_SKIP_CHECK_GRAD_CI}" != "" ]; then
207+
ERROR_LINES="${ERROR_LINES}\n${TEST_FILE}\n${HAS_SKIP_CHECK_GRAD_CI}\n"
208+
fi
209+
done
210+
if [ "${ERROR_LINES}" != "" ]; then
211+
ERROR_LINES=${ERROR_LINES//+/'\n+\t'}
212+
echo_line="You must have one RD (zhangting2020 (Recommend), luotao1 or phlrain) approval for the usage (either add or delete) of @skip_check_grad_ci. For more information, please refer to: https://github.com/PaddlePaddle/Paddle/wiki/Gradient-Check-Is-Required-for-Op-Test. The corresponding lines are as follows:\n${ERROR_LINES}\n"
213+
check_approval 1 26615455 6836917 43953930
214+
fi
215+
fi
216+
201217
if [ -n "${echo_list}" ];then
202218
echo "****************"
203219
echo -e "${echo_list[@]}"

0 commit comments

Comments
 (0)