Fixdownloadbug #363
Merged
Fixdownloadbug #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongweibao
commented
Aug 29, 2017
| c = NewChunk(m1.Size) | ||
| c.Len = m1.Size | ||
| c.Offset = m1.Offset | ||
| n, err := io.ReadFull(part, c.Data) |
Collaborator
Author
There was a problem hiding this comment.
bug主要在这里。
Read读数据其实读不完也会返回。
Collaborator
There was a problem hiding this comment.
一个multipart作为一个chunk?这样是否和上传时每个chunk的大小有区别呢？
Collaborator
Author
There was a problem hiding this comment.
没啥区别。multipart只不过是用boundary分割的一段buffer而已。
gongweibao
commented
Aug 29, 2017
| } | ||
| log.V(2).Infof("remote chunk is same as local chunk:%s\n\n", c.String()) | ||
| if errc == io.EOF || errm == io.EOF { | ||
| offset += sm.Len |
Collaborator
Author
There was a problem hiding this comment.
这个之前的offset也有问题。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #364