Skip to content

Fix unit test, make test fail immediately on error, rather than conti… #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2018
Merged

Fix unit test, make test fail immediately on error, rather than conti… #557

merged 3 commits into from
Jan 13, 2018

Conversation

helinwang
Copy link
Collaborator

…nue.

typhoonzero
typhoonzero approved these changes Jan 13, 2018
View reviewed changes
Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, github.com/stretchr/testify/require seems nice

@helinwang helinwang merged commit 11d79fc into PaddlePaddle:develop Jan 13, 2018
@helinwang helinwang deleted the fix_unit_test branch January 13, 2018 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helinwang @typhoonzero