Documentation updates #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidgoyal78
approved these changes
Apr 29, 2018
Collaborator
sidgoyal78
left a comment
sidgoyal78
left a comment
There was a problem hiding this comment.
LGTM, just a minor paraphrasing suggestion.
README.md
Outdated
| ## Status | ||
|
|
||
| ## Testing | ||
| Targets Paddle->ONNX conversion for now (or what's called **frontend** in the ONNX world), and will consequently support the reverse too. |
Collaborator
There was a problem hiding this comment.
Maybe targets -> "The current release targets"?
kuke
reviewed
Apr 29, 2018
README.md
Outdated
| python validate.py --fluid_model <path_to_paddlepaddle_fluid.model> --onnx_model <path_to_exported_model.onnx> | ||
| ``` | ||
|
|
||
| This validation aims for an output tensor comparison precision at 5-decimal places. |
There was a problem hiding this comment.
-> at 5-decimal places by default. About more arguments, please run
python validate.py --help
README.md
Outdated
| - Read the documents in the `How it works` section above. | ||
| - (Optional) Create an issue sharing need for support for a new model. Assign to yourself. | ||
| - Add the necessary operator conversion logic in `fluid_onnx/ops.py`. | ||
| - Write tests for the newly introduce operator convertors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just making the initial work visible, lots more to come