Move mongo field type logic into mongoadapter#1432
Merged
flovilmart merged 1 commit intoparse-community:masterfrom Apr 12, 2016
Merged
Move mongo field type logic into mongoadapter#1432flovilmart merged 1 commit intoparse-community:masterfrom
flovilmart merged 1 commit intoparse-community:masterfrom
Conversation
Current coverage is
|
b16b84b to
7a670fc
Compare
|
@drew-gross updated the pull request. |
| let found = false; | ||
| for (let i = 0; i < aclGroup.length && !found; i++) { | ||
| if (perms[aclGroup[i]]) { | ||
| found = true; |
Contributor
There was a problem hiding this comment.
It is weird to me to see the loop breaking it in the if statement, especially since you are doing a additional if for every iteration of the loop.
could this not just be done as the standard
if ( .. ) {
found = true;
break;
}
Contributor
Author
There was a problem hiding this comment.
Or even better: use Array.prototype.some. But I'd rather do that in a different PR.
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.