Adds ability to set an account lockout policy by cherukumilli · Pull Request #2601 · parse-community/parse-server

cherukumilli · 2016-08-28T17:42:32Z

This is a fix for issue #2508

Account lockout policy:

Someone who attempts to use more than a few unsuccessful passwords while trying to log on to your system might be a malicious user who is attempting to determine an account password by trial and error.

Update parse-server to track logon attempts and respond to this type of potential attack by disabling the account for a preset period of time

This setting will have 2 parameters:

Account lockout duration

The Account lockout duration policy setting determines the number of minutes that a locked-out account remains locked out before automatically becoming unlocked. The available range is from 1 through 99,999 minutes.

Account lockout threshold

The Account lockout threshold policy setting determines the number of failed sign-in attempts that will cause a user account to be locked. You can set a value from 1 through 999 failed sign-in attempts.

cherukumilli · 2016-08-29T13:27:50Z

@flovilmart
If you get a few mins then can you please restart travis CI?

flovilmart · 2016-08-29T13:55:18Z

spec/AccountLockoutPolicy.spec.js

+
+describe("Account Lockout Policy: ", () => {
+
+  it_exclude_dbs(['postgres'])('account should not be locked even after failed login attempts if account lockout policy is not set', done => {


what's the problem with PG?

I was under the impression that PG is not ready yet for testing and we are excluding test cases for PG.
Let me give the PG tests a shot and submit another pull request.

BTW: do you know if there is a workflow doc for contributing? i.e., a document that walks the contributor about the setup process, etc...

Not really, for PG, you need postgres > 9.4 with POSTGIS extensions loaded, and create the tables (see .travis.yml for the commands)

codecov-io · 2016-08-29T16:08:35Z

Current coverage is 92.11% (diff: 91.01%)

Merging #2601 into master will increase coverage by 0.02%

@@             master      #2601   diff @@
==========================================
  Files            99        100     +1   
  Lines         12113      12282   +169   
  Methods        1488       1522    +34   
  Messages          0          0          
  Branches       1996       2020    +24   
==========================================
+ Hits          11154      11313   +159   
- Misses          959        969    +10   
  Partials          0          0

Powered by Codecov. Last update f6516a1...67b5942

facebook-github-bot · 2016-08-29T16:08:41Z

@cherukumilli updated the pull request - view changes

ghost · 2016-08-29T19:56:25Z

@cherukumilli updated the pull request - view changes

flovilmart · 2016-08-30T01:28:18Z

Seems that there is an issue with PG on your PR. I'd still like to get it up and running for that DB.

you can debug the 3 failing tests

Account Lockout Policy: lock account if failed login attempts are above threshold
Account Lockout Policy: lock account for accountPolicy.duration minutes if failed login attempts are above threshold
Account Lockout Policy: allow login for locked account after accountPolicy.duration minutes

by replacing the it with a fit and also setting PARSE_SERVER_LOG_LEVEL=debug before running npm test like that:

PARSE_SERVER_LOG_LEVEL=debug PARSE_SERVER_TEST_DB=postgres npm test

cherukumilli · 2016-08-30T11:13:23Z

@flovilmart
Many thanks for the feedback and setting the environment variables. I will push a PR tomorrow after fixing the code to work with PG.

Is there a Contributor Workflow document that has the instructions like setting the environment variables? I wonder if I should add the instructions you provided above to the existing contributions document (https://github.com/ParsePlatform/parse-server/blob/master/CONTRIBUTING.md). It will be useful for other contributors.

flovilmart · 2016-08-30T11:19:00Z

@cherukumilli you're 100% right! We should add that to this file. I'll add it

ghost · 2016-08-31T13:30:32Z

@cherukumilli updated the pull request - view changes

flovilmart · 2016-08-31T13:32:11Z

src/Adapters/Storage/Postgres/PostgresStorageAdapter.js

+        }
        if (fieldName == '_perishable_token') {
-          valuesArray.push(object[fieldName].iso);
+          valuesArray.push(object[fieldName].iso); // TODO: check with @flovilmart about why .iso is needed here


this is probably an error...

cherukumilli · 2016-08-31T14:09:25Z

@flovilmart

Updating it to fit in the new AccountLockoutPolicy.spec.js file is causing only tests (10) in this file to be executed by npm test on my pc (locally).

Also I don't see any of the other test cases using fit.

ghost · 2016-08-31T14:13:15Z

@cherukumilli updated the pull request - view changes

ghost · 2016-08-31T14:17:05Z

@cherukumilli updated the pull request - view changes

nitrag · 2016-08-31T17:46:46Z

Nice PR! Was just thinking about the need for this last night!

ghost · 2016-08-31T18:26:54Z

@cherukumilli updated the pull request - view changes

flovilmart · 2016-08-31T20:49:28Z

Looking good, but change fit for it (otherwise only fit tests run :P)

ghost · 2016-09-02T19:45:37Z

@cherukumilli updated the pull request - view changes

flovilmart · 2016-09-02T20:53:47Z

Very neat feature as always @cherukumilli ! Thanks for your commitment to make it more secure!

cherukumilli · 2016-09-02T22:29:27Z

Thanks @flovilmart

btw: I see warnings and errors like the following in my local setup for PG GeoPoint tests in file ParseGeoPoint.spec.js. Do I need to do anything special to my local setup to get the GeoPoint tests working?

[33mwarn�[39m: Unable to ensure uniqueness for usernames:  code=107, message=schema class name does not revalidate

�[33mwarn�[39m: Unable to ensure uniqueness for user email addresses:  code=107, message=schema class name does not revalidate

F�[33mwarn�[39m: Unable to ensure uniqueness for usernames:  error: type "_SCHEMA" already exists
    at [object Object].Connection.parseE (/Users/diwakarcherukumilli/projects/parse/parse-server/node_modules/pg-promise/node_modules/pg/lib/connection.js:539:11)
    at [object Object].Connection.parseMessage (/Users/diwakarcherukumilli/projects/parse/parse-server/node_modules/pg-promise/node_modules/pg/lib/connection.js:366:17)
    at Socket.<anonymous> (/Users/diwakarcherukumilli/projects/parse/parse-server/node_modules/pg-promise/node_modules/pg/lib/connection.js:105:22)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:153:18)
    at Socket.Readable.push (_stream_readable.js:111:10)
    at TCP.onread (net.js:531:20)

Please see the attached file for error details after running command npm test ParseGeoPoint.spec.js

ParseGeoPoint.Errors.Errors.zip

flovilmart · 2016-09-02T22:43:44Z

Seems ok on Travis. Did you enable the postgis extension?

flovilmart · 2016-09-03T00:00:42Z

Looking very nice!! Thanks again!

cherukumilli · 2016-09-06T19:01:58Z

@flovilmart

Is this going to be targeted for v2.3.0?
If so, is there a target date for 2.30?

flovilmart · 2016-09-06T19:33:30Z

We don't have a target date for the next release, as soon as all Pr are merged for 2.2.19 we'll release.

ederelk · 2017-05-11T15:24:13Z

Hi all, @cherukumilli . It seems like a locked out account although not having access to the login api still can access other classes/objects with a valid session token. Why don't we remove all the user's session token when the user is locked out?

ederelk · 2017-05-11T15:52:23Z

@flovilmart @cherukumilli @facebook-github-bot Is there a way to actually lock the user out in cloud code?

cherukumilli · 2017-05-16T01:13:42Z

@ederelk
IMO, allowing valid session tokens access to the api other than login api is acceptable behavior.

For example:
User A logins from System X
User B (unauthorized user) tries to login from System Y unsuccessfully and ends up locking the account.

In the scenario above, IMO,

we should let User A continue to use their valid session token to use the application
lock the account so that User B is unable to login again for the lockout duration

Please let me know if you are seeing a security vulnerability that I am not seeing here.

ahmedu007 · 2018-05-23T09:35:20Z

@cherukumilli @facebook-github-bot @flavionegrao
Is there any documentation explaining this please?

ghost added the GH Review: review-needed label Aug 28, 2016

flovilmart reviewed Aug 29, 2016
View reviewed changes

flovilmart added GH Review: needs-revision and removed GH Review: review-needed labels Aug 30, 2016

facebook-github-bot added GH Review: review-needed and removed GH Review: needs-revision labels Aug 31, 2016

flovilmart reviewed Aug 31, 2016
View reviewed changes

cherukumilli added 2 commits September 2, 2016 12:44

Adds ability to set account lockout policy

f024832

change fit to it in tests

67b5942

flovilmart merged commit 28bd378 into parse-community:master Sep 3, 2016

cherukumilli deleted the account-lockout-policy branch September 3, 2016 16:17

cherukumilli mentioned this pull request Sep 10, 2016

Feature request: Parse User Account lockout policy setting #2508

Closed

JeremyPlease mentioned this pull request Sep 19, 2016

"invalid field name: _failed_login_count" from api.parse.com #2745

Closed


		describe("Account Lockout Policy: ", () => {

		it_exclude_dbs(['postgres'])('account should not be locked even after failed login attempts if account lockout policy is not set', done => {

Uh oh!

Conversation

cherukumilli commented Aug 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Account lockout policy:

Account lockout duration

Account lockout threshold

Uh oh!

cherukumilli commented Aug 29, 2016

Uh oh!

flovilmart Aug 29, 2016

Choose a reason for hiding this comment

Uh oh!

cherukumilli Aug 29, 2016

Choose a reason for hiding this comment

Uh oh!

flovilmart Aug 29, 2016

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Aug 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 92.11% (diff: 91.01%)

Uh oh!

facebook-github-bot commented Aug 29, 2016

Uh oh!

ghost commented Aug 29, 2016

Uh oh!

flovilmart commented Aug 30, 2016

Uh oh!

cherukumilli commented Aug 30, 2016

Uh oh!

flovilmart commented Aug 30, 2016

Uh oh!

ghost commented Aug 31, 2016

Uh oh!

flovilmart Aug 31, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cherukumilli commented Aug 31, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Aug 31, 2016

Uh oh!

ghost commented Aug 31, 2016

Uh oh!

nitrag commented Aug 31, 2016

Uh oh!

ghost commented Aug 31, 2016

Uh oh!

flovilmart commented Aug 31, 2016

Uh oh!

ghost commented Sep 2, 2016

Uh oh!

flovilmart commented Sep 2, 2016

Uh oh!

cherukumilli commented Sep 2, 2016

Uh oh!

flovilmart commented Sep 2, 2016

Uh oh!

flovilmart commented Sep 3, 2016

Uh oh!

cherukumilli commented Sep 6, 2016

Uh oh!

flovilmart commented Sep 6, 2016

Uh oh!

ederelk commented May 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ederelk commented May 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cherukumilli commented May 16, 2017

Uh oh!

ahmedu007 commented May 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

cherukumilli commented Aug 28, 2016 •

edited

Loading

codecov-io commented Aug 29, 2016 •

edited

Loading

flovilmart Aug 31, 2016 •

edited

Loading

cherukumilli commented Aug 31, 2016 •

edited

Loading

ederelk commented May 11, 2017 •

edited

Loading

ederelk commented May 11, 2017 •

edited

Loading