Skip to content

Improve update of jsonb fields. Add PG 9.5 to travis. #2984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flovilmart merged 2 commits into from
Nov 2, 2016
Merged

Improve update of jsonb fields. Add PG 9.5 to travis. #2984

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e99cf5
Improve update of jsonb fields. Add PG 9.5 to travis.
kulshekhar Nov 1, 2016
dc47daf
Replace manual escaping with pg-promise's built in
kulshekhar Nov 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Adapters/Storage/Postgres/PostgresStorageAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,11 +918,10 @@ export class PostgresStorageAdapter {
const keysToDelete = Object.keys(originalUpdate).filter(k => {
// choose top level fields that have a delete operation set
return originalUpdate[k].__op === 'Delete' && k.split('.').length === 2
}).map(k => k.split('.')[1])
.map(k => k.replace(/'/g, `''`));
}).map(k => k.split('.')[1]);

const deletePatterns = keysToDelete.reduce((p, c, i) => {
return p + ` - '$${index + 1 + i}:raw'`;
return p + ` - '$${index + 1 + i}:value'`;
}, '');

updatePatterns.push(`$${index}:name = ( COALESCE($${index}:name, '{}'::jsonb) ${deletePatterns} || $${index + 1 + keysToDelete.length}::jsonb )`);
Expand Down