Skip to content

Added test command for Windows support#886

Merged
drew-gross merged 3 commits intoparse-community:masterfrom
aneeshd16:patch-1
Mar 10, 2016
Merged

Added test command for Windows support#886
drew-gross merged 3 commits intoparse-community:masterfrom
aneeshd16:patch-1

Conversation

@aneeshd16
Copy link
Contributor

Use npm run test:win to run tests on Windows. Fixes #323.
Variables like $COVERAGE_OPTION are not supported in Windows.

Use `npm run test:win` to run tests on Windows. Fixes parse-community#323.
Variables like `$COVERAGE_OPTION` are not supported in Windows.
@codecov-io
Copy link

Current coverage is 90.56%

Merging #886 into master will decrease coverage by -0.79% as of 3c32a4c

@@            master    #886   diff @@
======================================
  Files           73      73       
  Stmts         4324    4324       
  Branches       863     863       
  Methods          0       0       
======================================
- Hit           3950    3916    -34
  Partial         10      10       
- Missed         364     398    +34

Review entire Coverage Diff as of 3c32a4c

Powered by Codecov. Updated on successful CI builds.

@steven-supersolid
Copy link
Contributor

Maybe we can remove the coverage checking from Windows as it will be checked in github? Could add coverage:win if we really want to check coverage in Windows.

@flovilmart
Copy link
Contributor

@steven-supersolid I have a better idea for that,

we could create a spec/coverage.js that would use the env variable through process.env.CODE_COVERAGE set or not to start / not start the coverage instead of adding so many scripts

@facebook-github-bot
Copy link

@aneeshd16 updated the pull request.

@facebook-github-bot
Copy link

@aneeshd16 updated the pull request.

drew-gross added a commit that referenced this pull request Mar 10, 2016
Added test command for Windows support
@drew-gross drew-gross merged commit d2cba75 into parse-community:master Mar 10, 2016
@aneeshd16 aneeshd16 deleted the patch-1 branch March 10, 2016 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants