fix: ensure that globals are set and checks present to avoid bench errs

* ECDSA benchmarks require ECC initialization, which was missing
* CheckBlock() internally calls `g_stats_client` and without a testing
  setup, it'll be a nullptr.
* Wallet benchmarks assume that TestingSetup will setup the CoinJoin
  loader but that is not guaranteed. We should check that the loader is
  available before attempting registration with it.

Author: kwvg

src/bench/bench_bitcoin.cpp

@@ -7,11 +7,9 @@
 #include <clientversion.h>
 #include <crypto/sha256.h>
 #include <fs.h>
-#include <stacktraces.h>
 #include <util/strencodings.h>
 #include <util/system.h>
 
-#include <bls/bls.h>
 #include <chrono>
 #include <cstdint>
 #include <iostream>

src/bench/checkblock.cpp

@@ -7,6 +7,7 @@
 
 #include <chainparams.h>
 #include <consensus/validation.h>
+#include <stats/client.h>
 #include <streams.h>
 #include <validation.h>
 
@@ -36,6 +37,9 @@ static void DeserializeAndCheckBlockTest(benchmark::Bench& bench)
 
     ArgsManager bench_args;
     const auto chainParams = CreateChainParams(bench_args, CBaseChainParams::MAIN);
+    // CheckBlock calls g_stats_client internally, we aren't using a testing setup
+    // so we need to do this manually.
+    ::g_stats_client = InitStatsClient(bench_args);
 
     bench.unit("block").run([&] {
         CBlock block; // Note that CBlock caches its checked state, so we need to recreate it here

src/bench/ecdsa.cpp

@@ -8,6 +8,8 @@
 
 static void ECDSASign(benchmark::Bench& bench)
 {
+    ECC_Start();
+
     std::vector<CKey> keys;
     std::vector<uint256> hashes;
     for (size_t i = 0; i < 100; i++) {
@@ -24,10 +26,14 @@ static void ECDSASign(benchmark::Bench& bench)
         keys[i].Sign(hashes[i], sig);
         i = (i + 1) % keys.size();
     });
+
+    ECC_Stop();
 }
 
 static void ECDSAVerify(benchmark::Bench& bench)
 {
+    ECC_Start();
+
     std::vector<CPubKey> keys;
     std::vector<uint256> hashes;
     std::vector<std::vector<unsigned char>> sigs;
@@ -47,10 +53,14 @@ static void ECDSAVerify(benchmark::Bench& bench)
         keys[i].Verify(hashes[i], sigs[i]);
         i = (i + 1) % keys.size();
     });
+
+    ECC_Stop();
 }
 
 static void ECDSAVerify_LargeBlock(benchmark::Bench& bench)
 {
+    ECC_Start();
+
     std::vector<CPubKey> keys;
     std::vector<uint256> hashes;
     std::vector<std::vector<unsigned char>> sigs;
@@ -70,6 +80,8 @@ static void ECDSAVerify_LargeBlock(benchmark::Bench& bench)
             keys[i].Verify(hashes[i], sigs[i]);
         }
     });
+
+    ECC_Stop();
 }
 
 BENCHMARK(ECDSASign)

src/wallet/load.cpp

@@ -161,6 +161,7 @@ void FlushWallets(WalletContext& context)
 {
     for (const std::shared_ptr<CWallet>& pwallet : GetWallets(context)) {
         if (CCoinJoinClientOptions::IsEnabled()) {
+            assert(pwallet->coinjoin_available());
             // Stop CoinJoin, release keys
             pwallet->coinjoin_loader().FlushWallet(pwallet->GetName());
         }

src/wallet/wallet.cpp

@@ -127,7 +127,9 @@ bool AddWallet(WalletContext& context, const std::shared_ptr<CWallet>& wallet)
     }
     wallet->ConnectScriptPubKeyManNotifiers();
     wallet->AutoLockMasternodeCollaterals();
-    wallet->coinjoin_loader().AddWallet(wallet);
+    if (wallet->coinjoin_available()) {
+        wallet->coinjoin_loader().AddWallet(wallet);
+    }
     wallet->NotifyCanGetAddressesChanged();
     return true;
 }
@@ -148,7 +150,9 @@ bool RemoveWallet(WalletContext& context, const std::shared_ptr<CWallet>& wallet
         context.wallets.erase(i);
     }
 
-    wallet->coinjoin_loader().RemoveWallet(name);
+    if (wallet->coinjoin_available()) {
+        wallet->coinjoin_loader().RemoveWallet(name);
+    }
 
     // Write the wallet setting
     UpdateWalletSetting(chain, name, load_on_start, warnings);