Skip to content

Commit 66f65c2

Browse files
MarcoFalkePastaPastaPasta
authored andcommitted
Merge bitcoin-core/gui#17: doc: Remove outdated comment in TransactionTablePriv
faebb60 doc: Remove outdated comment in TransactionTablePriv (MarcoFalke) Pull request description: Locks are no longer taken upfront, so remove the outdated comment ACKs for top commit: hebasto: ACK faebb60, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: cd6df24d49d17e58049ac9b261c5e07c8e85ed1aacb547b13c0e55139339d7fcc3b1f766ea2e27d758ea77deadc01f7e28781be1515323c82b9012cee8fd488b
1 parent a5ea9f8 commit 66f65c2

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

src/qt/transactiontablemodel.cpp

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -193,17 +193,12 @@ class TransactionTablePriv
193193

194194
TransactionRecord *index(interfaces::Wallet& wallet, int numBlocks, int idx)
195195
{
196-
if(idx >= 0 && idx < cachedWallet.size())
197-
{
196+
if (idx >= 0 && idx < cachedWallet.size()) {
198197
TransactionRecord *rec = &cachedWallet[idx];
199198

200-
// Get required locks upfront. This avoids the GUI from getting
201-
// stuck if the core is holding the locks for a longer time - for
202-
// example, during a wallet rescan.
203-
//
204199
// If a status update is needed (blocks came in since last check),
205-
// update the status of this transaction from the wallet. Otherwise,
206-
// simply re-use the cached status.
200+
// try to update the status of this transaction from the wallet.
201+
// Otherwise, simply re-use the cached status.
207202
interfaces::WalletTxStatus wtx;
208203
int64_t adjustedTime;
209204
if (rec->statusUpdateNeeded(numBlocks, parent->getChainLockHeight()) && wallet.tryGetTxStatus(rec->hash, wtx, adjustedTime)) {

0 commit comments

Comments
 (0)