Skip to content

Commit ad77a5b

Browse files
fanquakePastaPastaPasta
authored andcommitted
Merge bitcoin#24566: build: Drop redundant checks for ranlib and strip tools
a0e2a31 build: Drop redundant checks for ranlib and strip tools (Hennadii Stepanov) Pull request description: These checks are handled by the `LT_INIT` macro. Inspired by bitcoin-core/secp256k1#1088. On master (f3e0ace): ``` $ ./configure --with-incompatible-bdb 2>&1 | grep -n -E 'ranlib\.\.\.|strip\.\.\.' 56:checking for strip... strip 57:checking for ranlib... ranlib 102:checking for ranlib... /usr/bin/ranlib 103:checking for strip... /usr/bin/strip 380:checking for strip... strip 381:checking for ranlib... ranlib ``` With this PR: ``` $ ./configure --with-incompatible-bdb 2>&1 | grep -n -E 'ranlib\.\.\.|strip\.\.\.' 56:checking for strip... strip 57:checking for ranlib... ranlib 377:checking for strip... strip 378:checking for ranlib... ranlib $ CONFIG_SITE=$PWD/depends/x86_64-apple-darwin/share/config.site ./configure 2>&1 | grep -n -E 'ranlib\.\.\.|strip\.\.\.' 8:checking for x86_64-apple-darwin-strip... /home/hebasto/GitHub/bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-strip 61:checking for x86_64-apple-darwin-strip... (cached) /home/hebasto/GitHub/bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-strip 62:checking for x86_64-apple-darwin-ranlib... /home/hebasto/GitHub/bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-ranlib 188:checking whether the linker accepts -Wl,-dead_strip... yes 367:checking for x86_64-apple-darwin-strip... /home/hebasto/GitHub/bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-strip 411:checking for x86_64-apple-darwin-strip... (cached) /home/hebasto/GitHub/bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-strip 412:checking for x86_64-apple-darwin-ranlib... /home/hebasto/GitHub/bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-ranlib ``` #### Guix builds on `x86_64`: ``` ... ``` ACKs for top commit: real-or-random: ACK a0e2a31 fanquake: ACK a0e2a31 Tree-SHA512: 17e2f54a3fc0447d7a27592d4c803538b6e0dfe02eab9a234084d71f3d9244c2488d56301f6c57050592e0d760c2d48b2b7d365454754af2ce098e77c05d33cc
1 parent 67c1a8a commit ad77a5b

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

configure.ac

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,6 @@ LT_INIT([pic-only win32-dll])
9696

9797
dnl Check/return PATH for base programs.
9898
AC_PATH_TOOL([AR], [ar])
99-
AC_PATH_TOOL([RANLIB], [ranlib])
100-
AC_PATH_TOOL([STRIP], [strip])
10199
AC_PATH_TOOL([GCOV], [gcov])
102100
AC_PATH_TOOL([LLVM_COV], [llvm-cov])
103101
AC_PATH_PROG([LCOV], [lcov])

0 commit comments

Comments
 (0)