Skip to content

Conversation

@Rubenicos
Copy link
Contributor

No description provided.

@Phoenix616
Copy link
Owner

Thanks for your PR but I'm unsure which problem this really solves seeing as the click sounds should all be in the Sound class already. (Also I'm confused as to why you are using the map-keys in the NamespacedKey. Shouldn't it be the value?)

Also it looks like Paper doesn't even have the Registry.SOUNDS anymore (they use Registry.SOUND_EVENTS at least on 1.21.7) so if this addition is really necessary to solve a problem on newer versions that should be supported as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants