Feedback 1

Author: Andrew

resources/Microsoft.DSC.Experimental/0.0.1/Microsoft.DSC.Experimental.psd1

@@ -34,7 +34,7 @@ VariablesToExport = @()
 AliasesToExport = @()
 
 # DSC resources to export from this module
-DscResourcesToExport = 'Service'
+DscResourcesToExport = 'SystemctlService'
 
 # Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
 PrivateData = @{

resources/Microsoft.DSC.Experimental/0.0.1/Microsoft.DSC.Experimental.psm1

@@ -4,7 +4,7 @@
 using namespace System.Collections.Generic
 
 [DscResource()]
-class Service
+class SystemctlService
 {
     [DscProperty(Key)]
     [string] $Unit
@@ -30,46 +30,34 @@ class Service
         return $false
     }
 
-    [Service] Get()
+    [SystemctlService] Get()
     {
 
-        return [Service]::GetServices() | ? {$_.Unit -eq $this.Unit }
+        return [SystemctlService]::GetAll() | Where-Object {$_.Unit -eq $this.Unit }
     }
 
-    static [Service[]] Export()
+    static [SystemctlService[]] Export()
     {
-        $resultList = [List[Service]]::new()
-        $svcs = [Service]::GetServices()
-        $svcs | %{
-            $obj = New-Object Service
-            $obj.Unit = $_.Unit
-            $obj.Load = $_.Load
-            $obj.Active = $_.Active
-            $obj.Sub = $_.Sub
-            $obj.Description = $_.Description
-            
-            $resultList.Add($obj)
-        }
-
-        return $resultList.ToArray()
+        return [SystemctlService]::GetAll()
     }
 
-    static [pscustomobject[]] GetServices()
+    static [SystemctlService[]] GetAll()
     {
         $out = systemctl -l --type service --all
-        $resultList = [List[pscustomobject]]::new()
+        $resultList = [List[SystemctlService]]::new()
         $out | select-object -skip 1 | select-object -skiplast 7 | %{
             $arr = $_.split(" ", [System.StringSplitOptions]::RemoveEmptyEntries)
+            
+            if ($arr[2] -ne 'not-found') {
+                $obj = New-Object SystemctlService
+                $obj.Unit = $arr[0]
+                $obj.Load = $arr[1]
+                $obj.Active = $arr[2]
+                $obj.Sub = $arr[3]
+                $obj.Description = ($arr | select-object -last ($arr.Count - 4)) -join " "
 
-            $a = [pscustomobject]@{
-                Unit = $arr[0]
-                Load = $arr[1]
-                Active = $arr[2]
-                Sub = $arr[3]
-                Description = ($arr | select-object -last ($arr.Count - 4)) -join " "
+                $resultList.Add($obj)
             }
-
-            if ($a.active -ne 'not-found') { $resultList.Add($a)}
         }
         return $resultList.ToArray()
     }