Don't add empty lines to history

lzybkr · lzybkr · commit 52ba34535b75 · 2013-09-19T11:32:25.000-07:00
diff --git a/PSReadLine/ReadLine.cs b/PSReadLine/ReadLine.cs
@@ -345,7 +345,7 @@ void ProcessOneKey(ConsoleKeyInfo key, Dictionary<ConsoleKeyInfo, KeyHandler> di
 
         private string MaybeAddToHistory(string result)
         {
-            bool addToHistory = (_addToHistoryHandler == null) || _addToHistoryHandler(result);
+            bool addToHistory = !string.IsNullOrWhiteSpace(result) && ((_addToHistoryHandler == null) || _addToHistoryHandler(result));
             if (addToHistory && _historyNoDuplicates)
             {
                 // REVIEW: should history be case sensitive - it is now.

Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,7 @@ void ProcessOneKey(ConsoleKeyInfo key, Dictionary<ConsoleKeyInfo, KeyHandler> di`
`345`	`345`
`346`	`346`	`private string MaybeAddToHistory(string result)`
`347`	`347`	`{`
`348`		`- bool addToHistory = (_addToHistoryHandler == null) \|\| _addToHistoryHandler(result);`
	`348`	`+ bool addToHistory = !string.IsNullOrWhiteSpace(result) && ((_addToHistoryHandler == null) \|\| _addToHistoryHandler(result));`
`349`	`349`	`if (addToHistory && _historyNoDuplicates)`
`350`	`350`	`{`
`351`	`351`	`// REVIEW: should history be case sensitive - it is now.`