Skip to content

Review all the uses of _initialY and verify if the uses are safe when _initialY is negative #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daxian-dbw opened this issue Aug 30, 2019 · 1 comment
Assignees

Comments

@daxian-dbw
Copy link
Member

Given _initialY could be negative (e.g. multiple-line text editing causes the initial cursor position to be scrolled off the buffer), we need to review all the uses of _initialY and verify if the uses are safe when _initialY is negative.

@daxian-dbw
Copy link
Member Author

I reviewed all references to _initialY, and nothing obvious stands out. Also I reviewed all new issues and it looks none of them is related to _initialY becoming negative.
I tended to believe there is nothing we should do for now. If something related to this comes up, we will fix it at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant