Skip to content

Commit 0f82359

Browse files
author
Kapil Borle
committed
Minor changes to methods that implement finding wildcard or null in an ast in UseToExportFieldsInManifest.
1 parent f45004e commit 0f82359

File tree

1 file changed

+4
-18
lines changed

1 file changed

+4
-18
lines changed

Rules/UseToExportFieldsInManifest.cs

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -93,14 +93,7 @@ private bool IsValidManifest(Ast ast, string fileName)
9393
private bool HasWildcardInExpression(Ast ast)
9494
{
9595
var strConstExprAst = ast as StringConstantExpressionAst;
96-
if (strConstExprAst != null && WildcardPattern.ContainsWildcardCharacters(strConstExprAst.Value))
97-
{
98-
return true;
99-
}
100-
else
101-
{
102-
return false;
103-
}
96+
return strConstExprAst != null && WildcardPattern.ContainsWildcardCharacters(strConstExprAst.Value);
10497
}
10598

10699
/// <summary>
@@ -111,16 +104,9 @@ private bool HasWildcardInExpression(Ast ast)
111104
private bool HasNullInExpression(Ast ast)
112105
{
113106
var varExprAst = ast as VariableExpressionAst;
114-
if (varExprAst != null
115-
&& varExprAst.VariablePath.IsUnqualified
116-
&& varExprAst.VariablePath.UserPath.Equals("null", StringComparison.OrdinalIgnoreCase))
117-
{
118-
return true;
119-
}
120-
else
121-
{
122-
return false;
123-
}
107+
return varExprAst != null
108+
&& varExprAst.VariablePath.IsUnqualified
109+
&& varExprAst.VariablePath.UserPath.Equals("null", StringComparison.OrdinalIgnoreCase);
124110
}
125111

126112
/// <summary>

0 commit comments

Comments
 (0)