Merge pull request #297 from PowerShell/BugFixes

Take Bug fixes to Master

Author: raghushantha

Rules/AvoidUsingPlainTextForPassword.cs

@@ -37,7 +37,7 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
             // Finds all ParamAsts.
             IEnumerable<Ast> paramAsts = ast.FindAll(testAst => testAst is ParameterAst, true);
 
-            List<String> passwords = new List<String>() {"Password", "Passphrase"};
+            List<String> passwords = new List<String>() {"Password", "Passphrase", "Auth", "Cred", "Credential"};
 
             // Iterrates all ParamAsts and check if their names are on the list.
             foreach (ParameterAst paramAst in paramAsts)

Tests/Rules/AvoidUsingPlainTextForPassword.ps1

@@ -21,7 +21,9 @@
 	[securestring[]]
         $passwords,
 	$passphrases,
-	$passwordparam
+	$passwordparam,
+    $credential,
+    $auth
     )
 
     Begin

Tests/Rules/AvoidUsingPlainTextForPassword.tests.ps1

@@ -9,7 +9,7 @@ $noViolations = Invoke-ScriptAnalyzer $directory\AvoidUsingPlainTextForPasswordN
 Describe "AvoidUsingPlainTextForPassword" {
     Context "When there are violations" {
         It "has 3 avoid using plain text for password violations" {
-            $violations.Count | Should Be 3
+            $violations.Count | Should Be 5
         }
 
         It "has the correct violation message" {