Merge pull request #226 from PowerShell/FixAvoidUsingPlainTextForPasswordParameter

Quoc Truong · Quoc Truong · commit 962246d748b9 · 2015-05-29T11:34:57.000-07:00
Fix parameters missing in a conditional statement of the rule AvoidUsingPlainTextForPasswordParameter
diff --git a/Rules/AvoidUsingPlainTextForPassword.cs b/Rules/AvoidUsingPlainTextForPassword.cs
@@ -55,8 +55,8 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
                     }
                 }
 
-                if (hasPwd && (!paramType.IsArray && (paramType == typeof(String) || paramType == typeof(object)))
-                              || (paramType.IsArray && (paramType.GetElementType() == typeof(String) || paramType.GetElementType() == typeof(object))))
+                if (hasPwd && ((!paramType.IsArray && (paramType == typeof(String) || paramType == typeof(object)))
+                              || (paramType.IsArray && (paramType.GetElementType() == typeof(String) || paramType.GetElementType() == typeof(object)))))
                 {
                     yield return new DiagnosticRecord(
                         String.Format(CultureInfo.CurrentCulture, Strings.AvoidUsingPlainTextForPasswordError, paramAst.Name),
diff --git a/Tests/Rules/AvoidUsingPlainTextForPasswordNoViolations.ps1 b/Tests/Rules/AvoidUsingPlainTextForPasswordNoViolations.ps1
@@ -26,7 +26,9 @@
     [securestring]
 	$passwordparam,
     [string]
-    $PassThru
+    $PassThru,
+    [string[]]
+    $shouldnotraiseerror
     )
 
     Begin

Original file line number	Diff line number	Diff line change
`@@ -55,8 +55,8 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)`
`55`	`55`	`}`
`56`	`56`	`}`
`57`	`57`
`58`		`- if (hasPwd && (!paramType.IsArray && (paramType == typeof(String) \|\| paramType == typeof(object)))`
`59`		`- \|\| (paramType.IsArray && (paramType.GetElementType() == typeof(String) \|\| paramType.GetElementType() == typeof(object))))`
	`58`	`+ if (hasPwd && ((!paramType.IsArray && (paramType == typeof(String) \|\| paramType == typeof(object)))`
	`59`	`+ \|\| (paramType.IsArray && (paramType.GetElementType() == typeof(String) \|\| paramType.GetElementType() == typeof(object)))))`
`60`	`60`	`{`
`61`	`61`	`yield return new DiagnosticRecord(`
`62`	`62`	`String.Format(CultureInfo.CurrentCulture, Strings.AvoidUsingPlainTextForPasswordError, paramAst.Name),`