Simplify failing tests by inlining it and don't check the message as all we should really check is the rule violation

Author: JamesWTruher

Tests/Rules/AvoidPositionalParameters.ps1

@@ -1,21 +1,18 @@
 Import-Module PSScriptAnalyzer
-$violationMessage = "Cmdlet 'Get-Command' has positional parameter. Please use named parameters instead of positional parameters when calling a command."
-$violationName = "PSAvoidUsingPositionalParameters"
-$directory = Split-Path -Parent $MyInvocation.MyCommand.Path
-$violations = Invoke-ScriptAnalyzer $directory\AvoidPositionalParameters.ps1 | Where-Object {$_.RuleName -eq $violationName}
-$noViolations = Invoke-ScriptAnalyzer $directory\AvoidPositionalParametersNoViolations.ps1 | Where-Object {$_.RuleName -eq $violationName}
-$noViolationsDSC = Invoke-ScriptAnalyzer -ErrorAction SilentlyContinue $directory\serviceconfigdisabled.ps1 | Where-Object {$_.RuleName -eq $violationName}
 
 Describe "AvoidPositionalParameters" {
+    BeforeAll {
+        $directory = $PSScriptRoot
+        $violationName = "PSAvoidUsingPositionalParameters"
+        $violation = Invoke-ScriptAnalyzer -ScriptDefinition 'Get-Command "abc" 4 4.3'
+        $noViolations = Invoke-ScriptAnalyzer $directory\AvoidPositionalParametersNoViolations.ps1 | Where-Object {$_.RuleName -eq $violationName}
+        $noViolationsDSC = Invoke-ScriptAnalyzer -ErrorAction SilentlyContinue $directory\serviceconfigdisabled.ps1 | Where-Object {$_.RuleName -eq $violationName}
+    }
     Context "When there are violations" {
         It "has 1 avoid positional parameters violation" {
-            $violations.Count | Should -Be 1
-        }
-
-        It "has the correct description message" {
-            $violations[0].Message | Should -Match $violationMessage
+            @($violation).Count | Should -Be 1
+            $violation.RuleName | Should -Be $violationName
         }
-
     }
 
     Context "When there are no violations" {
@@ -27,4 +24,4 @@ Describe "AvoidPositionalParameters" {
             $noViolationsDSC.Count | Should -Be 0
         }
     }
-}
+}

Tests/Rules/AvoidPositionalParameters.tests.ps1

@@ -1,24 +1,19 @@
-Import-Module -Verbose PSScriptAnalyzer
-$violationMessage = "Cmdlet 'Write-Warning' may be used incorrectly. Please check that all mandatory parameters are supplied."
-$violationName = "PSUseCmdletCorrectly"
-$directory = Split-Path -Parent $MyInvocation.MyCommand.Path
-$violations = Invoke-ScriptAnalyzer $directory\UseCmdletCorrectly.ps1 | Where-Object {$_.RuleName -eq $violationName}
-$noViolations = Invoke-ScriptAnalyzer $directory\GoodCmdlet.ps1 | Where-Object {$_.RuleName -eq $violationName}
-
+
 Describe "UseCmdletCorrectly" {
     Context "When there are violations" {
         It "has 1 Use Cmdlet Correctly violation" {
-            $violations.Count | Should -Be 1
-        }
-
-        It "has the correct description message" {
-            $violations[0].Message | Should -Match $violationMessage
+            $violationName = "PSUseCmdletCorrectly"
+            $violation = Invoke-ScriptAnalyzer -ScriptDefinition 'Write-Warning;Write-Warning -Message "a warning"'
+            $violation.Count | Should -Be 1
+            $violation.RuleName | Should -Be $violationName
         }
     }
 
     Context "When there are no violations" {
         It "returns no violations" {
+            $directory = $PSScriptRoot
+            $noViolations = Invoke-ScriptAnalyzer $directory\GoodCmdlet.ps1 
             $noViolations.Count | Should -Be 0
         }
     }
-}
+}