Do not continue if a "Rules" setting key is non-unique

travisclagrone · travisclagrone · commit c7ff89b09ece · 2019-07-04T19:04:43.000-05:00
diff --git a/Engine/Settings.cs b/Engine/Settings.cs
@@ -469,7 +469,7 @@ private void ParseSettingsHashtable(Hashtable settings)
                                 exceptions.Add(new InvalidDataException(string.Format(
                                     Strings.SettingRuleKeyIsNotUniqueIgnoringCase,
                                     rule.Key)));
-                                continue;
+                                // Do not `continue` because even if an element's key is non-unique, that element's value may still be checked.
                             }
 
                             if (rule.Value is null)

Original file line number	Diff line number	Diff line change
`@@ -469,7 +469,7 @@ private void ParseSettingsHashtable(Hashtable settings)`
`469`	`469`	`exceptions.Add(new InvalidDataException(string.Format(`
`470`	`470`	`Strings.SettingRuleKeyIsNotUniqueIgnoringCase,`
`471`	`471`	`rule.Key)));`
`472`		`- continue;`
	`472`	+ // Do not `continue` because even if an element's key is non-unique, that element's value may still be checked.
`473`	`473`	`}`
`474`	`474`
`475`	`475`	`if (rule.Value is null)`