Fix broken test that depends on warning output

Author: daviwil

Tests/Engine/InvokeScriptAnalyzer.tests.ps1

@@ -223,7 +223,17 @@ Describe "Test CustomizedRulePath" {
     Context "When used incorrectly" {
         It "file cannot be found" {
             $wrongRule = Invoke-ScriptAnalyzer $directory\TestScript.ps1 -CustomizedRulePath "This is a wrong rule" 3>&1 | Select-Object -First 1
-            $wrongRule | Should Match "Cannot find rule extension 'This is a wrong rule'."
+
+			if ($testingLibraryUsage)
+			{
+				# Special case for library usage testing: warning output written
+				# with PSHost.UI.WriteWarningLine does not get redirected correctly
+				# so we can't use this approach for checking the warning message.
+				# Instead, reach into the test IOutputWriter implementation to find it.
+				$wrongRule = $testOutputWriter.MostRecentWarningMessage
+			}
+
+			$wrongRule | Should Match "Cannot find rule extension 'This is a wrong rule'."
         }
     }
 }

Tests/Engine/LibraryUsage.tests.ps1

@@ -33,7 +33,7 @@ function Invoke-ScriptAnalyzer {
 	$scriptAnalyzer = New-Object "Microsoft.Windows.PowerShell.ScriptAnalyzer.ScriptAnalyzer"
 	$scriptAnalyzer.Initialize(
 		$runspace, 
-		$outputWriter, 
+		$testOutputWriter, 
 		$CustomizedRulePath, 
 		$IncludeRule,
 		$ExcludeRule,
@@ -54,27 +54,32 @@ public class PesterTestOutputWriter : IOutputWriter
 {
 	private PSHost psHost;
 
+	public string MostRecentWarningMessage { get; private set; }
+
 	public static PesterTestOutputWriter Create(PSHost psHost)
 	{
-		PesterTestOutputWriter outputWriter = new PesterTestOutputWriter();
-		outputWriter.psHost = psHost;
-		return outputWriter;
+		PesterTestOutputWriter testOutputWriter = new PesterTestOutputWriter();
+		testOutputWriter.psHost = psHost;
+		return testOutputWriter;
 	}
 
-	// NOTE: We don't implement any Write methods to prevent console spew
-
 	public void WriteError(ErrorRecord error)
 	{
+		// We don't write errors to avoid misleading
+		// error messages in test output
 	}
 
 	public void WriteWarning(string message)
 	{
-		// Some tests look for warning messages, so write those out
 		psHost.UI.WriteWarningLine(message);
+
+		this.MostRecentWarningMessage = message;
 	}
 
 	public void WriteVerbose(string message)
 	{
+		// We don't write verbose output to avoid lots
+		// of unnecessary messages in test output
 	}
 
 	public void WriteDebug(string message)
@@ -92,9 +97,9 @@ public class PesterTestOutputWriter : IOutputWriter
 }
 "@ -ReferencedAssemblies "Microsoft.Windows.PowerShell.ScriptAnalyzer" -ErrorAction SilentlyContinue
 
-if ($outputWriter -eq $null)
+if ($testOutputWriter -eq $null)
 {
-	$outputWriter = [PesterTestOutputWriter]::Create($Host);
+	$testOutputWriter = [PesterTestOutputWriter]::Create($Host);
 }
 
 # Create a fresh runspace to pass into the ScriptAnalyzer class