UseShouldProcessCorrectly should analyze downstream function calls

[richardszalay]

It's not uncommon to have a function that doesn't make use of ShouldProcess itself, but calls child functions that do. Here's an example:

function Outer
{
    [CmdletBinding(SupportsShouldProcess=$true)]
    param()

    Inner
}

function Inner
{
    [CmdletBinding(SupportsShouldProcess=$true)]
    param()

    if ($PSCmdlet.ShouldProcess("Inner"))
    {
        Write-Host "Process!"
    }
    else
    {
        Write-Host "Skipped!"
    }
}

Outer -WhatIf

UseShouldProcessCorrectly triggers in these scenarios, but arguably shouldn't since it runs as expected.

(It's quite possible that I've missed a standard convention here that makes this issue irrelevant, so feel free to correct me if that's the case)

[Jaykul]

How many times do we have to complain about this?

I'm sick of writing:

    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSShouldProcess")] # Because PSSCriptAnalyzer can't see Set-Content...
    [CmdletBinding(SupportsShouldProcess)]

See #194 #283 #521