Fix unintentional module import. (#1484)

MartinGC94 · web-flow · commit 03fc2562591d · 2021-05-24T10:35:03.000-07:00
Fixes PowerShell/vscode-powershell#715 by not getting command documentation unless the module has already been imported.
diff --git a/src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs b/src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs
@@ -117,6 +117,12 @@ public async Task<CompletionItem> Handle(CompletionItem request, CancellationTok
                 return request;
             }
 
+            // No details means the module hasn't been imported yet and Intellisense shouldn't import the module to get this info.
+            if (request.Detail is null)
+            {
+                return request;
+            }
+
             try
             {
                 await _completionResolveLock.WaitAsync(cancellationToken).ConfigureAwait(false);

Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,12 @@ public async Task<CompletionItem> Handle(CompletionItem request, CancellationTok`
`117`	`117`	`return request;`
`118`	`118`	`}`
`119`	`119`
	`120`	`+ // No details means the module hasn't been imported yet and Intellisense shouldn't import the module to get this info.`
	`121`	`+ if (request.Detail is null)`
	`122`	`+ {`
	`123`	`+ return request;`
	`124`	`+ }`
	`125`	`+`
`120`	`126`	`try`
`121`	`127`	`{`
`122`	`128`	`await _completionResolveLock.WaitAsync(cancellationToken).ConfigureAwait(false);`