skip function ast visit for FunctionMemberAst

Author: fflaten

src/PowerShellEditorServices/Services/Symbols/Vistors/FindDeclarationVisitor.cs

@@ -36,6 +36,13 @@ public FindDeclarationVisitor(SymbolReference symbolRef)
         /// or a decision to continue if it wasn't found</returns>
         public override AstVisitAction VisitFunctionDefinition(FunctionDefinitionAst functionDefinitionAst)
         {
+            // Extent for constructors and method trigger both this and VisitFunctionMember(). Covered in the latter.
+            // This will not exclude nested functions as they have ScriptBlockAst as parent
+            if (functionDefinitionAst.Parent is FunctionMemberAst)
+            {
+                return AstVisitAction.Continue;
+            }
+
             // Get the start column number of the function name,
             // instead of the the start column of 'function' and create new extent for the functionName
             int startColumnNumber =

src/PowerShellEditorServices/Services/Symbols/Vistors/FindReferencesVisitor.cs

@@ -117,6 +117,13 @@ public override AstVisitAction VisitCommand(CommandAst commandAst)
         /// <returns>A visit action that continues the search for references</returns>
         public override AstVisitAction VisitFunctionDefinition(FunctionDefinitionAst functionDefinitionAst)
         {
+            // Extent for constructors and method trigger both this and VisitFunctionMember(). Covered in the latter.
+            // This will not exclude nested functions as they have ScriptBlockAst as parent
+            if (functionDefinitionAst.Parent is FunctionMemberAst)
+            {
+                return AstVisitAction.Continue;
+            }
+
             (int startColumnNumber, int startLineNumber) = VisitorUtils.GetNameStartColumnAndLineNumbersFromAst(functionDefinitionAst);
 
             IScriptExtent nameExtent = new ScriptExtent()

src/PowerShellEditorServices/Services/Symbols/Vistors/FindSymbolVisitor.cs

@@ -58,6 +58,13 @@ public override AstVisitAction VisitCommand(CommandAst commandAst)
         /// or a decision to continue if it wasn't found</returns>
         public override AstVisitAction VisitFunctionDefinition(FunctionDefinitionAst functionDefinitionAst)
         {
+            // Extent for constructors and method trigger both this and VisitFunctionMember(). Covered in the latter.
+            // This will not exclude nested functions as they have ScriptBlockAst as parent
+            if (functionDefinitionAst.Parent is FunctionMemberAst)
+            {
+                return AstVisitAction.Continue;
+            }
+
             int startLineNumber = functionDefinitionAst.Extent.StartLineNumber;
             int startColumnNumber = functionDefinitionAst.Extent.StartColumnNumber;
             int endLineNumber = functionDefinitionAst.Extent.EndLineNumber;

src/PowerShellEditorServices/Services/Symbols/Vistors/FindSymbolsVisitor.cs

@@ -25,7 +25,8 @@ public override AstVisitAction VisitFunctionDefinition(FunctionDefinitionAst fun
         {
             // Extent for constructors and method trigger both this and VisitFunctionMember(). Covered in the latter.
             // This will not exclude nested functions as they have ScriptBlockAst as parent
-            if (functionDefinitionAst.Parent is FunctionMemberAst) {
+            if (functionDefinitionAst.Parent is FunctionMemberAst)
+            {
                 return AstVisitAction.Continue;
             }