Skip to content

Fix tests in Language/LanguageServiceTests.cs #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andyleejordan opened this issue Mar 29, 2021 · 0 comments · Fixed by #1655
Closed

Fix tests in Language/LanguageServiceTests.cs #1445

andyleejordan opened this issue Mar 29, 2021 · 0 comments · Fixed by #1655
Labels
Area-Test Issue-Bug A bug to squash.

Comments

@andyleejordan
Copy link
Member

This file has most of its tests in place, but there are a few that need fixing:

[Fact(Skip = "TODO Fix this test. A possible bug in PSES product code.")]
public void LanguageServiceFindsReferencesOnCommandWithAlias()

[Fact(Skip = "TODO Fix this test. A possible bug in PSES product code.")]
public void LanguageServiceFindsReferencesOnAlias()

// TODO: Bring this back when we can use AstVisitor2 again (#276)
//Assert.Equal(1, symbolsResult.FoundOccurrences.Where(r => r.SymbolType == SymbolType.Configuration).Count());
//SymbolReference firstConfigurationSymbol = symbolsResult.FoundOccurrences.Where(r => r.SymbolType == SymbolType.Configuration).First();
//Assert.Equal("AConfiguration", firstConfigurationSymbol.SymbolName);
//Assert.Equal(25, firstConfigurationSymbol.ScriptRegion.StartLineNumber);
//Assert.Equal(1, firstConfigurationSymbol.ScriptRegion.StartColumnNumber);

@ghost ghost added the Needs: Triage Maintainer attention needed! label Mar 29, 2021
@SydneyhSmith SydneyhSmith added Issue-Bug A bug to squash. and removed Needs: Triage Maintainer attention needed! labels Mar 30, 2021
@ghost ghost added the Status: In PR label Jan 7, 2022
@ghost ghost added Status: Fixed and removed Status: In PR labels Jan 7, 2022
@andyleejordan andyleejordan moved this to Done in Sea Biscuit Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Test Issue-Bug A bug to squash.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants