Skip to content

Refactor Start-EditorServices.ps1 based on feedback #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TylerLeonhardt opened this issue Apr 23, 2018 · 2 comments
Closed

Refactor Start-EditorServices.ps1 based on feedback #656

TylerLeonhardt opened this issue Apr 23, 2018 · 2 comments
Labels
Area-Startup Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@TylerLeonhardt
Copy link
Member

There is some feedback given in this PR of some parameter clean up:
#629

It wasn't blocking for the PR so this is the issue to remember to do that refactoring.
@TylerLeonhardt TylerLeonhardt added Issue-Enhancement A feature request (enhancement). Area-General Up for Grabs Will shepherd PRs. labels Apr 23, 2018
@rjmholt rjmholt changed the title Reactor Start-EditorServices.ps1 based on feedback Refactor Start-EditorServices.ps1 based on feedback Apr 23, 2018
@jpogran
Copy link

jpogran commented Oct 3, 2019

Most, if not all of the feedback mentioned seems to already have been accomplished in 487ad1d. I think this can be closed

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Oct 3, 2019
@TylerLeonhardt
Copy link
Member Author

Yep! You're totally right. We can close this. @rjmholt will be refactoring it more (porting to a binary module) but that doesn't need this to be open.

@TylerLeonhardt TylerLeonhardt removed the Needs: Maintainer Attention Maintainer attention needed! label Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Startup Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpogran @TylerLeonhardt @SydneyhSmith