Implement psedit command for remote file loading #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
reviewed
Jan 17, 2017
| scriptFile = editorSession.Workspace.GetFile(setBreakpointsParams.Source.Path); | ||
| } | ||
| catch (FileNotFoundException) | ||
| catch (DirectoryNotFoundException e) |
Contributor
There was a problem hiding this comment.
You could use:
catch (Exception ex) when (ex is FileNotFoundException || ex is DirectoryNotFoundException)
{
notFoundException = ex;
}
Contributor
Author
There was a problem hiding this comment.
Hah! Yep, haven't had a chance to use that one yet.
rkeithhill
approved these changes
Jan 17, 2017
Contributor
rkeithhill
left a comment
rkeithhill
left a comment
There was a problem hiding this comment.
Cool new functionality! Firing an event from PowerShell and catching it in C# - nice. The Logger.WriteException() methods should be handy as well.
Contributor
Author
|
Doesn't work in all cases yet unfortunately. Seems that either PowerShell isn't forwarding the event all the way from nested sessions (debugging a runspace in a local or remote process) back to the local session. I'll have to bug somebody about that today. |
This change adds new behavior to RemoteFileManager so that a 'psedit' command will be added to all sessions for the purpose of loading local or remote files in the debugging experience. For now the remotely opened files do not have new contents propagated to the remote machine but that will be added shortly.
This change adds the !ctrlc and !break commands which are special to the debug adapter's REPL interface. The provide the ability to send a Ctrl+C (abort) or Ctrl+B (break) at any time. This is necessary because the debugger UI can't properly handle or transfer these commands in some cases.
daviwil
force-pushed
the
daviwil/remote-file-open
branch
from
10539ad to
62f1e5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds new behavior to RemoteFileManager so that a 'psedit'
command will be added to all sessions for the purpose of loading local or
remote files in the debugging experience. For now the remotely opened
files do not have saved contents propagated to the remote machine but that
will be added shortly.