Skip to content

Commit 0d47940

Browse files
committed
Scan *.vsix instead of signing
Since Visual Studio Code extensions cannot be signed. We originally tried signing the extension because it was listed in `signing.xml` but since this is a Code (and not just Visual Studio) extension, it comes back as an unrecognized file format when being signed.
1 parent 4bbaca7 commit 0d47940

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

.vsts-ci/templates/release-general.yml

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,24 +55,21 @@ steps:
5555
- template: EsrpSign.yml@ComplianceRepo
5656
parameters:
5757
buildOutputPath: '$(Build.ArtifactStagingDirectory)/vscode-powershell'
58-
signOutputPath: '$(Build.ArtifactStagingDirectory)/ScriptSigned'
58+
signOutputPath: '$(Build.ArtifactStagingDirectory)/Signed'
5959
alwaysCopy: true # So publishing works
6060
certificateId: 'CP-230012' # Authenticode certificate
6161
useMinimatch: true # This enables the use of globbing
62+
# NOTE: Code AKA *.vsix files are not signed
6263
pattern: |
6364
Install-VSCode.ps1
6465
65-
- template: EsrpSign.yml@ComplianceRepo
66+
- template: EsrpScan.yml@ComplianceRepo
6667
parameters:
67-
buildOutputPath: '$(Build.ArtifactStagingDirectory)/ScriptSigned'
68-
signOutputPath: '$(Build.ArtifactStagingDirectory)/ExtensionSigned'
69-
alwaysCopy: true # So publishing works
70-
certificateId: 'CP-233016' # Microsoft OPC Publisher (VSIX) certificate
71-
useMinimatch: true # This enables the use of globbing
72-
pattern: |
73-
PowerShell-insiders.vsix
68+
scanPath: $(Build.ArtifactStagingDirectory)/Signed
69+
pattern: |
70+
*.vsix
7471
75-
- publish: $(Build.ArtifactsDirectory)/ExtensionSigned
72+
- publish: $(Build.ArtifactStagingDirectory)/Signed
7673
artifact: vscode-powershell
7774
displayName: 'Publish signed (and unsigned) artifacts'
7875

0 commit comments

Comments
 (0)