Make CI build template actually generic

This now uses a repository resource or the triggering pipeline artifact
to provide the PowerShellEditorServices sources (or bits). Coupled with
the change to the build script, this means the template can be used to
build for CI or for a release.

We also moved to zipped pipeline artifacts as build artifacts have been
deprecated, but we need to reduce the cost of the stored artifacts
themselves. These are provided for developers to test and for the
release pipeline to use.

Author: andyleejordan

.vsts-ci/azure-pipelines-ci.yml

@@ -13,6 +13,14 @@ trigger:
     include:
       - master
 
+resources:
+  repositories:
+  - repository: PowerShellEditorServices
+    type: github
+    endpoint: GitHub
+    name: PowerShell/PowerShellEditorServices
+    ref: master
+
 jobs:
 - job: Win2019
   displayName: Windows Server 2019

.vsts-ci/templates/ci-general.yml

@@ -1,30 +1,57 @@
+parameters:
+  - name: usePipelineArtifact
+    type: boolean
+    default: false
+
 steps:
-  - pwsh: '$PSVersionTable'
+- pwsh: $PSVersionTable
   displayName: PowerShell version
 
-  - pwsh: Write-Host "##vso[build.updatebuildnumber]$env:BUILD_SOURCEBRANCHNAME-$env:BUILD_SOURCEVERSION-$((get-date).ToString("yyyyMMddhhmmss"))"
-    displayName: Set Build Name for Non-PR
-    condition: ne(variables['Build.Reason'], 'PullRequest')
+- checkout: self
 
-    # TODO: Use a submodule or some such so we can actually track a version here.
-  - pwsh: |
-      git clone https://github.com/PowerShell/PowerShellEditorServices.git ../PowerShellEditorServices
-      Install-Module InvokeBuild -Scope CurrentUser -Force
-      Install-Module PlatyPS -Scope CurrentUser -Force
-      New-Item -ItemType Directory $(Build.ArtifactStagingDirectory)/vscode-powershell
+# NOTE: We either checkout the Git repo for PowerShellEditorServices, or we
+# download a pre-built artifact from the triggering pipeline and extract it to
+# the modules folder. In this way we do not accidentally build a release of the
+# server from this pipeline.
+- checkout: PowerShellEditorServices
+  condition: not(${{ parameters.usePipelineArtifact }})
 
-  # Build
-  - pwsh: Invoke-Build
+- task: DownloadPipelineArtifact@2
+  condition: ${{ parameters.usePipelineArtifact }}
+  displayName: Download PowerShellEditorServices
+  inputs:
+    source: specific
+    project: PowerShellEditorServices
+    pipeline: 36
+    preferTriggeringPipeline: true
+    allowPartiallySucceededBuilds: true
+    artifact: PowerShellEditorServices
 
-  - task: PublishTestResults@2
-  displayName: Publish test results
-    inputs:
-      testRunner: JUnit
-      testResultsFiles: '**/test-results.xml'
-    condition: succeededOrFailed()
+- task: ExtractFiles@1
+  condition: ${{ parameters.usePipelineArtifact }}
+  displayName: Extract PowerShellEditorServices module
+  inputs:
+    archiveFilePatterns: $(Pipeline.Workspace)/PowerShellEditorServices.zip
+    destinationFolder: $(Build.SourcesDirectory)/vscode-powershell/modules
+
+- pwsh: |
+    Install-Module InvokeBuild -Scope CurrentUser -Force
+    Invoke-Build
+    Write-Host "##vso[task.setvariable variable=vsixPath]$(Resolve-Path powershell-*.vsix)"
+  displayName: Build and test
+  workingDirectory: $(Build.SourcesDirectory)/vscode-powershell
 
-  - task: PublishBuildArtifacts@1
-    inputs:
-      ArtifactName: vscode-powershell
-      PathtoPublish: '$(Build.ArtifactStagingDirectory)/vscode-powershell'
+- publish: $(vsixPath)
+  artifact: vscode-powershell-vsix-$(System.JobId)
+  displayName: Publish extension artifact
 
+- publish: $(Build.SourcesDirectory)/vscode-powershell/scripts/Install-VSCode.ps1
+  artifact: vscode-powershell-unsigned-script-$(System.JobId)
+  displayName: Publish unsigned script artifact
+
+- task: PublishTestResults@2
+  displayName: Publish test results
+  inputs:
+    testRunner: JUnit
+    testResultsFiles: '**/test-results.xml'
+  condition: succeededOrFailed()