Skip to content

Theme switching during install of the extension #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rkeithhill opened this issue Apr 9, 2020 · 4 comments
Closed

Theme switching during install of the extension #2624

rkeithhill opened this issue Apr 9, 2020 · 4 comments
Labels
Resolution-Duplicate Will close automatically.

Comments

@rkeithhill
Copy link
Contributor

Summary of the new feature

I see this a fair amount as I switch between installs of stable and preview:

image

I'll NEVER EVER EVER want the ISE color scheme in VSCode. 😛

Rather than just switching the whole color scheme (even if just temporarily), what if the extension popped up a notification asking if the user wants to try the ISE (light) color scheme before switching (or even previewing) the color scheme. Or maybe add a setting to disable this?

What I don't know is if this something we do in the extension or if this is just a "feature" of VSCode when it detects a theme in an extension. Hmm, looks like this might just be a feature of VSCode.

@ghost ghost added the Needs: Triage Maintainer attention needed! label Apr 9, 2020
@rjmholt
Copy link
Contributor

rjmholt commented Apr 9, 2020

See #1943. VSCode closed as wontfix in microsoft/vscode#73224

@rjmholt
Copy link
Contributor

rjmholt commented Apr 9, 2020

To expand, we've always bundled the theme, and one day VSCode changed behaviours to be more helpful, now this happens and the onus has been shifted to us to create a new deployment pipeline for a second extension just so that this doesn't happen.

@rkeithhill
Copy link
Contributor Author

rkeithhill commented Apr 9, 2020

Gotcha. You can close this then if you want. Not too much we can do atm.

@rjmholt rjmholt added Resolution-Duplicate Will close automatically. and removed Needs: Triage Maintainer attention needed! labels Apr 9, 2020
@ghost
Copy link

ghost commented Apr 10, 2020

This issue has been marked as duplicate and has not had any activity for 1 day. It has been closed for housekeeping purposes.

@ghost ghost closed this as completed Apr 10, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate Will close automatically.
Projects
None yet
Development

No branches or pull requests

2 participants