-
Notifications
You must be signed in to change notification settings - Fork 1.3k
8620 modulenotfounderror no module named onnxscript in test py3x 311 pipeline #8638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
…script-in-test-py3x-311-pipeline
I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: ba56a6d Signed-off-by: R. Garcia-Dias <[email protected]>
Signed-off-by: R. Garcia-Dias <[email protected]>
WalkthroughThe pull request modifies Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Areas requiring extra attention:
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: 9f4d989 Signed-off-by: R. Garcia-Dias <[email protected]>
…script-in-test-py3x-311-pipeline Signed-off-by: Rafael Garcia-Dias <[email protected]>
for more information, see https://pre-commit.ci
Fixes #8620 .
Description
Adds
onnxscriptas an explicit dependency.I have tried to find where this onnxscript package was coming from before. For that, I tried all Python versions from 3.9 to 3.12, all versions of onnxruntime and onnx_graphsurgeon, and all versions later than 1.13.0 of onnx.
None of these would include
onnxscript.I suppose that this was a requirement of another library and was removed in some new version.
I don't think it is worth the trouble of further investigating to find which package it was, since we wouldn't want to freeze a package version for this reason. So, instead, I propose we just add onnxscript as a dependency.
Potential issue
I am not sure if this will trigger the running of the ONNX tests in Python < 3.10 and how it will impact those tests.
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.