Skip to content

Commit 3376aef

Browse files
committed
fix(BRIDGE-515): replace old go syntax using go:fix to match new go 1.26 syntax
1 parent 2728d73 commit 3376aef

53 files changed

Lines changed: 135 additions & 173 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

async/panic_handler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
package async
22

33
type PanicHandler interface {
4-
HandlePanic(interface{})
4+
HandlePanic(any)
55
}
66

77
type NoopPanicHandler struct{}
88

9-
func (n NoopPanicHandler) HandlePanic(r interface{}) {}
9+
func (n NoopPanicHandler) HandlePanic(r any) {}
1010

1111
func HandlePanic(panicHandler PanicHandler) {
1212
if panicHandler == nil {

async/panic_handler_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99

1010
type recoverHandler struct{}
1111

12-
func (h recoverHandler) HandlePanic(r interface{}) {
12+
func (h recoverHandler) HandlePanic(r any) {
1313
fmt.Println("recoverHandler", r)
1414
}
1515

benchmarks/gluon_bench/benchmark/run.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ func RunMain() {
7878

7979
benchmarkStats := make([]*reporter.BenchmarkStatistics, 0, numRuns)
8080

81-
for r := uint(0); r < numRuns; r++ {
81+
for r := range numRuns {
8282
if *flags.Verbose {
8383
fmt.Printf("Benchmark Run: %v\n", r)
8484
}

benchmarks/gluon_bench/imap_benchmarks/build_mailbox.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func BuildMailbox(cl *client.Client, mailbox string, messageCount int) error {
3535
func BuildMailboxWithMessages(cl *client.Client, mailbox string, messageCount int, messages []string) error {
3636
messagesLen := len(messages)
3737

38-
for i := 0; i < messageCount; i++ {
38+
for i := range messageCount {
3939
literal := fmt.Sprintf("To: %v@a.com\r\nFrom: %v@a.com\r\n", uuid.NewString(), uuid.NewString()) + messages[i%messagesLen]
4040
if err := AppendToMailbox(cl, mailbox, literal, time.Now()); err != nil {
4141
return err

benchmarks/gluon_bench/imap_benchmarks/client.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ func FetchMessage(cl *client.Client, sequenceSet *imap.SeqSet, items ...imap.Fet
3434
return cl.Fetch(sequenceSet, items, ch)
3535
}
3636

37-
func flagsToInterface(flags ...string) []interface{} {
38-
return xslices.Map(flags, func(f string) interface{} {
39-
return interface{}(f)
37+
func flagsToInterface(flags ...string) []any {
38+
return xslices.Map(flags, func(f string) any {
39+
return any(f)
4040
})
4141
}
4242

benchmarks/gluon_bench/imap_benchmarks/parallel_seqset.go

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ func NewParallelSeqSetFromFile(path string, numWorkers uint) (*ParallelSeqSet, e
2626
}
2727

2828
seqSets := make([][]*imap.SeqSet, numWorkers)
29-
for i := uint(0); i < numWorkers; i++ {
29+
for i := range numWorkers {
3030
seqSets[i] = list
3131
}
3232

@@ -43,11 +43,11 @@ func NewParallelSeqSetExpunge(count uint32, numWorkers uint, generateIntervals,
4343
workerSplit := count / uint32(numWorkers)
4444
available := make([]uint32, count)
4545

46-
for r := uint32(0); r < count; r++ {
46+
for r := range count {
4747
available[r] = r + 1
4848
}
4949

50-
for i := uint(0); i < numWorkers; i++ {
50+
for i := range numWorkers {
5151
available := available[(uint32(i) * workerSplit):(uint32(i+1) * workerSplit)]
5252
list := make([]*imap.SeqSet, 0, workerSplit)
5353

@@ -80,7 +80,7 @@ func NewParallelSeqSetExpunge(count uint32, numWorkers uint, generateIntervals,
8080
}
8181
} else {
8282
count := uint32(len(available))
83-
for r := uint32(0); r < count; r++ {
83+
for r := range count {
8484
index := rand.Uint32() % (count - r)
8585
seqSet := &imap.SeqSet{}
8686
if uid {
@@ -106,12 +106,12 @@ func NewParallelSeqSetExpunge(count uint32, numWorkers uint, generateIntervals,
106106
func NewParallelSeqSetRandom(count uint32, numWorkers uint, generateIntervals, randomDrain, uid bool) *ParallelSeqSet {
107107
lists := make([][]*imap.SeqSet, numWorkers)
108108

109-
for i := uint(0); i < numWorkers; i++ {
109+
for i := range numWorkers {
110110
list := make([]*imap.SeqSet, 0, count)
111111

112112
if randomDrain {
113113
available := make([]uint32, count)
114-
for r := uint32(0); r < count; r++ {
114+
for r := range count {
115115
available[r] = r + 1
116116
}
117117

@@ -134,11 +134,7 @@ func NewParallelSeqSetRandom(count uint32, numWorkers uint, generateIntervals, r
134134
if uid {
135135
seqSet.AddRange(available[index], available[index+intervalRange-1])
136136
} else {
137-
endSeq := index + intervalRange + 1
138-
139-
if endSeq > itemsLeft {
140-
endSeq = itemsLeft
141-
}
137+
endSeq := min(index+intervalRange+1, itemsLeft)
142138

143139
seqSet.AddRange(index+1, endSeq)
144140
}
@@ -153,7 +149,7 @@ func NewParallelSeqSetRandom(count uint32, numWorkers uint, generateIntervals, r
153149
available = append(available[:cutIndex], available[index+intervalRange:]...)
154150
}
155151
} else {
156-
for r := uint32(0); r < count; r++ {
152+
for r := range count {
157153
index := rand.Uint32() % (count - r)
158154
seqSet := &imap.SeqSet{}
159155
if uid {
@@ -167,7 +163,7 @@ func NewParallelSeqSetRandom(count uint32, numWorkers uint, generateIntervals, r
167163
}
168164
}
169165
} else {
170-
for r := uint32(0); r < count; r++ {
166+
for range count {
171167
var seqSet *imap.SeqSet
172168
if !generateIntervals {
173169
seqSet = RandomSequenceSetNum(count)
@@ -188,7 +184,7 @@ func NewParallelSeqSetRandom(count uint32, numWorkers uint, generateIntervals, r
188184
// NewParallelSeqSetAll generates once sequence set for each worker which covers everything (1:*).
189185
func NewParallelSeqSetAll(numWorkers uint) *ParallelSeqSet {
190186
lists := make([][]*imap.SeqSet, numWorkers)
191-
for i := uint(0); i < numWorkers; i++ {
187+
for i := range numWorkers {
192188
lists[i] = []*imap.SeqSet{NewSequenceSetAll()}
193189
}
194190

benchmarks/gluon_bench/imap_benchmarks/search.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ func (s *SearchTextQuery) Run(ctx context.Context, cl *client.Client, workerInde
120120

121121
fieldsStr := []string{"TEXT", s.queries[keywordIndex]}
122122

123-
fields := xslices.Map(fieldsStr, func(v string) interface{} {
124-
return interface{}(v)
123+
fields := xslices.Map(fieldsStr, func(v string) any {
124+
return any(v)
125125
})
126126

127127
if err := criteria.ParseWithCharset(fields, nil); err != nil {
@@ -162,7 +162,7 @@ func (s *SearchSinceQuery) Setup(ctx context.Context, cl *client.Client, searchC
162162
} else {
163163
s.dates = make([]string, 0, searchCount)
164164

165-
for i := uint32(0); i < searchCount; i++ {
165+
for range searchCount {
166166
t := time.Date(1980+rand.Intn(40), time.Month(rand.Intn(12)), rand.Intn(28), 0, 0, 0, 0, time.UTC)
167167
s.dates = append(s.dates, t.Format("02-Jan-2006"))
168168
}
@@ -181,8 +181,8 @@ func (s *SearchSinceQuery) Run(ctx context.Context, cl *client.Client, workerInd
181181

182182
fieldsStr := []string{"SINCE", d}
183183

184-
fields := xslices.Map(fieldsStr, func(v string) interface{} {
185-
return interface{}(v)
184+
fields := xslices.Map(fieldsStr, func(v string) any {
185+
return any(v)
186186
})
187187

188188
if err := criteria.ParseWithCharset(fields, nil); err != nil {
@@ -215,8 +215,8 @@ func (s *SearchCmdQuery) Setup(ctx context.Context, cl *client.Client, searchCou
215215

216216
queries := strings.Split(*searchCmdQueryFlag, " ")
217217

218-
fields := xslices.Map(queries, func(v string) interface{} {
219-
return interface{}(v)
218+
fields := xslices.Map(queries, func(v string) any {
219+
return any(v)
220220
})
221221

222222
if err := s.criteria.ParseWithCharset(fields, nil); err != nil {

benchmarks/gluon_bench/reporter/reporter.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package reporter
33
import (
44
"fmt"
55
"math"
6-
"sort"
6+
"slices"
77
"strings"
88
"time"
99

@@ -39,9 +39,7 @@ func (b *BenchmarkStatistics) String() string {
3939

4040
func NewBenchmarkStatistics(extra BenchmarkExtra, durations ...time.Duration) *BenchmarkStatistics {
4141
sortedDurations := durations
42-
sort.Slice(sortedDurations, func(i1, i2 int) bool {
43-
return sortedDurations[i1] < sortedDurations[i2]
44-
})
42+
slices.Sort(sortedDurations)
4543

4644
statistics := &BenchmarkStatistics{
4745
Extra: extra,

benchmarks/gluon_bench/store_benchmarks/get.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func (g *Get) Run(ctx context.Context, st store.Store) (*reporter.BenchmarkRun,
3939
uuidLen := len(g.uuids)
4040

4141
return RunStoreWorkers(ctx, st, func(ctx context.Context, s store.Store, dc *timing.Collector, u uint) error {
42-
for i := 0; i < uuidLen; i++ {
42+
for range uuidLen {
4343
index := rand.Intn(uuidLen)
4444

4545
dc.Start()

benchmarks/gluon_bench/store_benchmarks/utils.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ func CreateRandomState(st store.Store, count uint) ([]imap.InternalMessageID, er
1717
uuids := make([]imap.InternalMessageID, 0, count)
1818
data := make([]byte, *flags.StoreItemSize)
1919

20-
for i := uint(0); i < count; i++ {
20+
for range count {
2121
uuid := imap.NewInternalMessageID()
2222

2323
if err := st.Set(uuid, bytes.NewReader(data)); err != nil {
@@ -65,10 +65,7 @@ func RunStoreWorkersSplitRange(ctx context.Context, st store.Store, length uint,
6565
workDivision := length / *flags.StoreWorkers
6666

6767
return RunStoreWorkers(ctx, st, func(ctx context.Context, s store.Store, collector *timing.Collector, u uint) error {
68-
end := workDivision * (u + 1)
69-
if end > length {
70-
end = length
71-
}
68+
end := min(workDivision*(u+1), length)
7269

7370
return fn(ctx, st, collector, u*workDivision, end)
7471
})

0 commit comments

Comments
 (0)