Skip to content

Commit 3a86725

Browse files
Update to use PrepareVerify (#210)
Fixes the build issues with #191
1 parent 7f9da72 commit 3a86725

File tree

1 file changed

+17
-5
lines changed

1 file changed

+17
-5
lines changed

openpgp/packet/public_key.go

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -849,7 +849,11 @@ func keySignatureHash(pk, signed signingKey, hashFunc hash.Hash) (h hash.Hash, e
849849
// VerifyKeyHashTag returns nil iff sig appears to be a plausible signature over this
850850
// primary key and subkey, based solely on its HashTag.
851851
func (pk *PublicKey) VerifyKeyHashTag(signed *PublicKey, sig *Signature) error {
852-
h, err := keySignatureHash(pk, signed, sig.Hash)
852+
preparedHash, err := sig.PrepareVerify()
853+
if err != nil {
854+
return err
855+
}
856+
h, err := keySignatureHash(pk, signed, preparedHash)
853857
if err != nil {
854858
return err
855859
}
@@ -902,11 +906,15 @@ func keyRevocationHash(pk signingKey, hashFunc hash.Hash) (err error) {
902906
// VerifyRevocationHashTag returns nil iff sig appears to be a plausible signature
903907
// over this public key, based solely on its HashTag.
904908
func (pk *PublicKey) VerifyRevocationHashTag(sig *Signature) (err error) {
905-
h, err := keyRevocationHash(pk, sig.Hash)
909+
preparedHash, err := sig.PrepareVerify()
906910
if err != nil {
907911
return err
908912
}
909-
return VerifyHashTag(h, sig)
913+
err = keyRevocationHash(pk, preparedHash)
914+
if err != nil {
915+
return err
916+
}
917+
return VerifyHashTag(preparedHash, sig)
910918
}
911919

912920
// VerifyRevocationSignature returns nil iff sig is a valid signature, made by this
@@ -968,11 +976,15 @@ func directKeySignatureHash(pk *PublicKey, h hash.Hash) (err error) {
968976
// VerifyUserIdHashTag returns nil iff sig appears to be a plausible signature over this
969977
// public key and UserId, based solely on its HashTag
970978
func (pk *PublicKey) VerifyUserIdHashTag(id string, sig *Signature) (err error) {
971-
h, err := userIdSignatureHash(id, pk, sig.Hash)
979+
preparedHash, err := sig.PrepareVerify()
972980
if err != nil {
973981
return err
974982
}
975-
return VerifyHashTag(h, sig)
983+
err = userIdSignatureHash(id, pk, preparedHash)
984+
if err != nil {
985+
return err
986+
}
987+
return VerifyHashTag(preparedHash, sig)
976988
}
977989

978990
// VerifyUserIdSignature returns nil iff sig is a valid signature, made by this

0 commit comments

Comments
 (0)