Skip to content

KeyExpired() function should use the *key* creation time, not the *sig* #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fawkesley opened this issue Oct 24, 2018 · 1 comment
Closed

KeyExpired() function should use the *key* creation time, not the *sig* #10

fawkesley opened this issue Oct 24, 2018 · 1 comment

Comments

@fawkesley
Copy link
Contributor

Hello!

I see you've made some mods to KeyExpired - cool!

It seems you've still got the same issue as golang/crypto though, that expiry should be calculated from the key creation time, not the signature creation time:

golang/go#22312
@twiss
Copy link
Member

twiss commented Apr 27, 2019

Fixed by 31f8b48 :)

@twiss twiss closed this as completed Apr 27, 2019
@andrewgdotcom andrewgdotcom mentioned this issue Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fawkesley @twiss