11using ECommons . DalamudServices ;
2- using Lumina . Excel . GeneratedSheets ;
2+ using Lumina . Excel . Sheets ;
33using System ;
44using System . Collections . Generic ;
55using System . Globalization ;
66using System . Linq ;
77using System . Runtime . CompilerServices ;
88using XIVSlothCombo . Combos . PvE ;
9+ using XIVSlothCombo . CustomComboNS . Functions ;
910
1011namespace XIVSlothCombo . Attributes
1112{
@@ -14,41 +15,33 @@ namespace XIVSlothCombo.Attributes
1415 internal class CustomComboInfoAttribute : Attribute
1516 {
1617 /// <summary> Initializes a new instance of the <see cref="CustomComboInfoAttribute"/> class. </summary>
17- /// <param name="fancyName "> Display name. </param>
18+ /// <param name="name "> Display name. </param>
1819 /// <param name="description"> Combo description. </param>
1920 /// <param name="jobID"> Associated job ID. </param>
2021 /// <param name="order"> Display order. </param>
2122 /// <param name="memeName"> Display meme name </param>
2223 /// <param name="memeDescription"> Meme description. </param>
23- internal CustomComboInfoAttribute ( string fancyName , string description , byte jobID , [ CallerLineNumber ] int order = 0 , string memeName = "" , string memeDescription = "" )
24+ internal CustomComboInfoAttribute ( string name , string description , byte jobID , [ CallerLineNumber ] int order = 0 )
2425 {
25- FancyName = fancyName ;
26+ Name = name ;
2627 Description = description ;
2728 JobID = jobID ;
2829 Order = order ;
29- MemeName = memeName ;
30- MemeDescription = memeDescription ;
3130 }
3231
3332 /// <summary> Gets the display name. </summary>
34- public string FancyName { get ; }
35-
36- ///<summary> Gets the meme name. </summary>
37- public string MemeName { get ; }
33+ public string Name { get ; }
3834
3935 /// <summary> Gets the description. </summary>
4036 public string Description { get ; }
4137
42- /// <summary> Gets the meme description. </summary>
43- public string MemeDescription { get ; }
44-
4538 /// <summary> Gets the job ID. </summary>
4639 public byte JobID { get ; }
4740
4841 /// <summary> Gets the job role. </summary>
49- public int Role => JobIDToRole ( JobID ) ;
42+ public int Role => CustomComboFunctions . JobIDs . JobIDToRole ( JobID ) ;
5043
51- public uint ClassJobCategory => JobIDToClassJobCategory ( JobID ) ;
44+ public uint ClassJobCategory => CustomComboFunctions . JobIDs . JobIDToClassJobCategory ( JobID ) ;
5245
5346 private static int JobIDToRole ( byte jobID )
5447 {
@@ -61,7 +54,7 @@ private static int JobIDToRole(byte jobID)
6154 private static uint JobIDToClassJobCategory ( byte jobID )
6255 {
6356 if ( Svc . Data . GetExcelSheet < ClassJob > ( ) . HasRow ( jobID ) )
64- return Svc . Data . GetExcelSheet < ClassJob > ( ) . GetRow ( jobID ) . ClassJobCategory . Row ;
57+ return Svc . Data . GetExcelSheet < ClassJob > ( ) . GetRow ( jobID ) . ClassJobCategory . RowId ;
6558
6659 return 0 ;
6760 }
@@ -70,7 +63,7 @@ private static uint JobIDToClassJobCategory(byte jobID)
7063 public int Order { get ; }
7164
7265 /// <summary> Gets the job name. </summary>
73- public string JobName => JobIDToName ( JobID ) ;
66+ public string JobName => CustomComboFunctions . JobIDs . JobIDToName ( JobID ) ;
7467
7568 public string JobShorthand => JobIDToShorthand ( JobID ) ;
7669
@@ -84,7 +77,7 @@ private static string JobIDToShorthand(byte key)
8477
8578 if ( ClassJobs . TryGetValue ( key , out var job ) )
8679 {
87- return job . Abbreviation . RawString ;
80+ return job . Abbreviation . ToString ( ) ;
8881 }
8982 else
9083 {
@@ -102,10 +95,10 @@ public static string JobIDToName(byte key)
10295 //Override DOH/DOL
10396 if ( key is DOH . JobID ) key = 08 ; //Set to Carpenter
10497 if ( key is DOL . JobID ) key = 16 ; //Set to Miner
105- if ( ClassJobs . TryGetValue ( key , out ClassJob ? job ) )
98+ if ( ClassJobs . TryGetValue ( key , out ClassJob job ) )
10699 {
107100 //Grab Category name for DOH/DOL, else the normal Name for the rest
108- string jobname = key is 08 or 16 ? job . ClassJobCategory . Value . Name : job . Name ;
101+ string jobname = key is 08 or 16 ? job . ClassJobCategory . Value . Name . ToString ( ) : job . Name . ToString ( ) ;
109102 //Job names are all lowercase by default. This capitalizes based on regional rules
110103 string cultureID = Svc . ClientState . ClientLanguage switch
111104 {
0 commit comments