Skip to content

Load pylint plugins before pylint config#237

Merged
chocoelho merged 1 commit into
prospector-dev:masterfrom
twidi:correctly-load-pylint-plugins-options
May 25, 2018
Merged

Load pylint plugins before pylint config#237
chocoelho merged 1 commit into
prospector-dev:masterfrom
twidi:correctly-load-pylint-plugins-options

Conversation

@twidi

@twidi twidi commented Oct 8, 2017

Copy link
Copy Markdown
Contributor

It's the way it's done by pylint in its own runner to load the config.

This way, the plugins correctly have access to their options.

Fixes #232

It's the way it's done by pylint in its own runner to load the config.

This way, the plugins correctly have access to their options.

Fixes prospector-dev#232
@coveralls

coveralls commented Oct 8, 2017

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 58.502% when pulling 221df28 on twidi:correctly-load-pylint-plugins-options into c9122a8 on landscapeio:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 58.448% when pulling 221df28 on twidi:correctly-load-pylint-plugins-options into c9122a8 on landscapeio:master.

@twidi

twidi commented Oct 8, 2017

Copy link
Copy Markdown
Contributor Author

I uploaded a package named prospector-fixes-232 on pypi, which just the version 0.12.7 with my fix. I needed it

Ping #232

@chocoelho chocoelho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @twidi. Will release a patch with your fix soon 👍

@chocoelho chocoelho merged commit 7502179 into prospector-dev:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants