Skip to content

New release - 1.0#261

Merged
carlio merged 33 commits into
masterfrom
develop
Jul 23, 2018
Merged

New release - 1.0#261
carlio merged 33 commits into
masterfrom
develop

Conversation

@carlio

@carlio carlio commented Jul 22, 2018

Copy link
Copy Markdown
Member

@chocoelho want to check over this?

This would create an new release with

  1. several PRs merged in (mostly yours!)
  2. moving versioning to more simple 1.0 - original versioning was just to make sure people knew it was a beta/work in progress but that was 5 years ago...
  3. various fixes with latest versions of pylint/astroid
  4. drops support for python 3.3 (deprecated so might as well ignore it)

chocoelho and others added 30 commits August 14, 2017 16:38
Signed-off-by: Carlos Coêlho <carlospecter@gmail.com>
Add option to set pylintrc inside prospector.yml
…etector/pylint dependency to get more up-to-date code
@carlio carlio requested a review from chocoelho July 22, 2018 09:39
@coveralls

coveralls commented Jul 22, 2018

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 606

  • 20 of 92 (21.74%) changed or added relevant lines in 9 files are covered.
  • 248 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-2.2%) to 76.2%

Changes Missing Coverage Covered Lines Changed/Added Lines %
prospector/tools/pylint/linter.py 2 6 33.33%
prospector/config/datatype.py 4 8 50.0%
prospector/config/init.py 1 6 16.67%
prospector/run.py 2 14 14.29%
prospector/tools/mypy/init.py 2 49 4.08%
Files with Coverage Reduction New Missed Lines %
prospector/formatters/text.py 1 64.29%
prospector/tools/utils.py 2 82.76%
prospector/encoding.py 5 66.67%
prospector/finder.py 6 83.59%
prospector/tools/pylint/linter.py 7 64.71%
prospector/message.py 8 74.58%
prospector/config/init.py 8 80.21%
prospector/tools/pylint/collector.py 9 76.92%
prospector/tools/pep257/init.py 10 80.65%
prospector/tools/pylint/indent_checker.py 11 80.77%
Totals Coverage Status
Change from base Build 596: -2.2%
Covered Lines: 1492
Relevant Lines: 1958

💛 - Coveralls

@carlio carlio merged commit 9f0d445 into master Jul 23, 2018
@chocoelho

Copy link
Copy Markdown
Contributor

@carlio sorry for not checking this out earlier, things are going crazy over here because my wife is going to give birth in a couple of months. One thing I'm concerned is related to mypy new releases, it looks like they changed the API a little bit, but I'm going to check this out this week and if something changed I'll open up another PR to fix what's needed.

@carlio

carlio commented Jul 23, 2018

Copy link
Copy Markdown
Member Author

@chocoelho no worries - I have finally got my self organised enough to work a bit more on this and other projects so don't worry about it. And congratulations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants