feat: add terminal bell setting to enable/disable audio notifications#1194
Merged
pomelo-nwu merged 3 commits intoQwenLM:mainfrom Dec 13, 2025
Merged
feat: add terminal bell setting to enable/disable audio notifications#1194pomelo-nwu merged 3 commits intoQwenLM:mainfrom
pomelo-nwu merged 3 commits intoQwenLM:mainfrom
Conversation
Contributor
Author
Contributor
|
@afarber Thank you for your contribution! I've already tested it and everything is fine. We will merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TLDR
Adds a user-facing general.terminalBell setting that lets users toggle the terminal bell notification on/off via the settings dialog. The terminal bell feature already existed but wasn't configurable - this PR wires up the setting so users can disable it if they find it annoying.
Dive Deeper
The terminal bell (\u0007) was already being emitted by notifyTerminalAttention() when:
The changes are minimal:
Default is true to preserve existing behavior.
Reviewer Test Plan
Testing Matrix
Linked issues / bugs
Closes #1193