[fix] fix normalization issue of mktime and timegm

milo-9 · mysterywolf · commit 3ca5cd53f53d · 2026-01-17T19:12:40.000-05:00
diff --git a/components/libc/compilers/common/ctime.c b/components/libc/compilers/common/ctime.c
@@ -391,7 +391,6 @@ time_t timegm(struct tm * const t)
         return (time_t)-1;
     }
 
-    years = (time_t)t->tm_year - 70;
     if (t->tm_sec > 60)         /* seconds after the minute - [0, 60] including leap second */
     {
         t->tm_min += t->tm_sec / 60;
@@ -433,6 +432,8 @@ time_t timegm(struct tm * const t)
         return (time_t) -1;
     }
 
+    years = (time_t)t->tm_year - 70;
+
     /* Days since 1970 is 365 * number of years + number of leap years since 1970 */
     day = years * 365 + (years + 1) / 4;
 

Original file line number	Diff line number	Diff line change
`@@ -391,7 +391,6 @@ time_t timegm(struct tm * const t)`
`391`	`391`	`return (time_t)-1;`
`392`	`392`	`}`
`393`	`393`
`394`		`- years = (time_t)t->tm_year - 70;`
`395`	`394`	`if (t->tm_sec > 60) /* seconds after the minute - [0, 60] including leap second */`
`396`	`395`	`{`
`397`	`396`	`t->tm_min += t->tm_sec / 60;`
`@@ -433,6 +432,8 @@ time_t timegm(struct tm * const t)`
`433`	`432`	`return (time_t) -1;`
`434`	`433`	`}`
`435`	`434`
	`435`	`+ years = (time_t)t->tm_year - 70;`
	`436`	`+`
`436`	`437`	`/* Days since 1970 is 365 * number of years + number of leap years since 1970 */`
`437`	`438`	`day = years * 365 + (years + 1) / 4;`
`438`	`439`