Skip to content

rotate_y has bounding box with incorrect time #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trevordblack opened this issue Oct 6, 2020 · 5 comments
Closed

rotate_y has bounding box with incorrect time #749

trevordblack opened this issue Oct 6, 2020 · 5 comments
Assignees
Milestone

Comments

@trevordblack
Copy link
Collaborator

trevordblack commented Oct 6, 2020

rotate_y::rotate_y(shared_ptr<hittable> p, double angle) : ptr(p) {
  auto radians = degrees_to_radians(angle);
  sin_theta = sin(radians);
  cos_theta = cos(radians); 
  hasbox = ptr->bounding_box(0, 1, bbox);
  ...

where

hasbox = ptr->bounding_box(0, 1, bbox);

the 0 and 1 need to be determined at runtime

@hollasch
Copy link
Collaborator

hollasch commented Oct 6, 2020

Oif.

@hollasch hollasch added this to the v3.2.2 milestone Oct 6, 2020
@trevordblack
Copy link
Collaborator Author

box_compare has similar problems

@trevordblack trevordblack self-assigned this Oct 6, 2020
@trevordblack
Copy link
Collaborator Author

rotate_y requires removing hasbox and just solving for the bounding-box of the base ptr lazily.

box_compare will require passing the time0|1 parameters down

@hollasch
Copy link
Collaborator

See comments in #770. The current bounding box implementation has design problems. Deferring to v4.0.0.

@hollasch hollasch modified the milestones: v3.2.2, v4.0.0 Oct 26, 2020
@hollasch hollasch self-assigned this Oct 29, 2020
@hollasch
Copy link
Collaborator

See #799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants