Skip to content

Commit d27a27b

Browse files
Add OnSubscribeFunction and refactor to support it
This is related to ongoing work related to covariant support at ReactiveX/RxJava#331
1 parent 5adbba2 commit d27a27b

File tree

4 files changed

+15
-19
lines changed

4 files changed

+15
-19
lines changed

src/main/java/rx/swing/sources/AbstractButtonSource.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,7 @@
1515
*/
1616
package rx.swing.sources;
1717

18-
import static org.mockito.Mockito.mock;
19-
import static org.mockito.Mockito.never;
20-
import static org.mockito.Mockito.times;
21-
import static org.mockito.Mockito.verify;
18+
import static org.mockito.Mockito.*;
2219

2320
import java.awt.event.ActionEvent;
2421
import java.awt.event.ActionListener;
@@ -29,20 +26,21 @@
2926
import org.mockito.Matchers;
3027

3128
import rx.Observable;
29+
import rx.Observable.OnSubscribeFunc;
3230
import rx.Observer;
3331
import rx.Subscription;
32+
import rx.observables.SwingObservable;
3433
import rx.subscriptions.Subscriptions;
3534
import rx.util.functions.Action0;
3635
import rx.util.functions.Action1;
37-
import rx.util.functions.Func1;
3836

3937
public enum AbstractButtonSource { ; // no instances
4038

4139
/**
4240
* @see SwingObservable.fromButtonAction
4341
*/
4442
public static Observable<ActionEvent> fromActionOf(final AbstractButton button) {
45-
return Observable.create(new Func1<Observer<? super ActionEvent>, Subscription>() {
43+
return Observable.create(new OnSubscribeFunc<ActionEvent>() {
4644
@Override
4745
public Subscription call(final Observer<? super ActionEvent> observer) {
4846
final ActionListener listener = new ActionListener() {

src/main/java/rx/swing/sources/ComponentEventSource.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,15 @@
1515
*/
1616
package rx.swing.sources;
1717

18-
import static rx.swing.sources.ComponentEventSource.Predicate.RESIZED;
18+
import static rx.swing.sources.ComponentEventSource.Predicate.*;
1919

2020
import java.awt.Component;
2121
import java.awt.Dimension;
2222
import java.awt.event.ComponentEvent;
2323
import java.awt.event.ComponentListener;
2424

2525
import rx.Observable;
26+
import rx.Observable.OnSubscribeFunc;
2627
import rx.Observer;
2728
import rx.Subscription;
2829
import rx.observables.SwingObservable;
@@ -36,7 +37,7 @@ public enum ComponentEventSource { ; // no instances
3637
* @see SwingObservable.fromComponentEvents
3738
*/
3839
public static Observable<ComponentEvent> fromComponentEventsOf(final Component component) {
39-
return Observable.create(new Func1<Observer<? super ComponentEvent>, Subscription>() {
40+
return Observable.create(new OnSubscribeFunc<ComponentEvent>() {
4041
@Override
4142
public Subscription call(final Observer<? super ComponentEvent> observer) {
4243
final ComponentListener listener = new ComponentListener() {

src/main/java/rx/swing/sources/KeyEventSource.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,8 @@
1515
*/
1616
package rx.swing.sources;
1717

18-
import static java.util.Arrays.asList;
19-
import static org.mockito.Mockito.inOrder;
20-
import static org.mockito.Mockito.mock;
21-
import static org.mockito.Mockito.never;
22-
import static org.mockito.Mockito.times;
23-
import static org.mockito.Mockito.verify;
18+
import static java.util.Arrays.*;
19+
import static org.mockito.Mockito.*;
2420

2521
import java.awt.Component;
2622
import java.awt.event.KeyEvent;
@@ -36,12 +32,12 @@
3632
import org.mockito.Matchers;
3733

3834
import rx.Observable;
35+
import rx.Observable.OnSubscribeFunc;
3936
import rx.Observer;
4037
import rx.Subscription;
4138
import rx.subscriptions.Subscriptions;
4239
import rx.util.functions.Action0;
4340
import rx.util.functions.Action1;
44-
import rx.util.functions.Func1;
4541
import rx.util.functions.Func2;
4642

4743
public enum KeyEventSource { ; // no instances
@@ -50,7 +46,7 @@ public enum KeyEventSource { ; // no instances
5046
* @see SwingObservable.fromKeyEvents(Component)
5147
*/
5248
public static Observable<KeyEvent> fromKeyEventsOf(final Component component) {
53-
return Observable.create(new Func1<Observer<? super KeyEvent>, Subscription>() {
49+
return Observable.create(new OnSubscribeFunc<KeyEvent>() {
5450
@Override
5551
public Subscription call(final Observer<? super KeyEvent> observer) {
5652
final KeyListener listener = new KeyListener() {

src/main/java/rx/swing/sources/MouseEventSource.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,20 @@
2121
import java.awt.event.MouseMotionListener;
2222

2323
import rx.Observable;
24+
import rx.Observable.OnSubscribeFunc;
2425
import rx.Observer;
2526
import rx.Subscription;
27+
import rx.observables.SwingObservable;
2628
import rx.subscriptions.Subscriptions;
2729
import rx.util.functions.Action0;
28-
import rx.util.functions.Func1;
2930

3031
public enum MouseEventSource { ; // no instances
3132

3233
/**
3334
* @see SwingObservable.fromMouseEvents
3435
*/
3536
public static Observable<MouseEvent> fromMouseEventsOf(final Component component) {
36-
return Observable.create(new Func1<Observer<? super MouseEvent>, Subscription>() {
37+
return Observable.create(new OnSubscribeFunc<MouseEvent>() {
3738
@Override
3839
public Subscription call(final Observer<? super MouseEvent> observer) {
3940
final MouseListener listener = new MouseListener() {
@@ -78,7 +79,7 @@ public void call() {
7879
* @see SwingObservable.fromMouseMotionEvents
7980
*/
8081
public static Observable<MouseEvent> fromMouseMotionEventsOf(final Component component) {
81-
return Observable.create(new Func1<Observer<? super MouseEvent>, Subscription>() {
82+
return Observable.create(new OnSubscribeFunc<MouseEvent>() {
8283
@Override
8384
public Subscription call(final Observer<? super MouseEvent> observer) {
8485
final MouseMotionListener listener = new MouseMotionListener() {

0 commit comments

Comments
 (0)