Skip to content

Upstream API changes to Godot #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 tasks
RedMser opened this issue Apr 30, 2024 · 1 comment
Open
4 tasks

Upstream API changes to Godot #11

RedMser opened this issue Apr 30, 2024 · 1 comment
Labels
meta Related to the repository, or the CI/CD upstream Depends on an upstream issue or PR, can't be solved immediately version:forked Specific to the Forked version of the extension

Comments

@RedMser
Copy link
Owner

RedMser commented Apr 30, 2024

Applied in fork

Not yet implemented

  • Backwards compatibility methods for the "args" parameter.
  • ScriptEditor::open_file only checks for Script and JSON resources to determine what it can open
    • TODO: should check if this is also what determines if double-clicking a file in FileSystem dock opens the script editor
@RedMser RedMser added the upstream Depends on an upstream issue or PR, can't be solved immediately label Apr 30, 2024
@RedMser RedMser added version:forked Specific to the Forked version of the extension meta Related to the repository, or the CI/CD labels May 4, 2024
@RedMser
Copy link
Owner Author

RedMser commented May 7, 2025

Once Godot supports loading Fluent translations on startup, it might not be worth maintaining an engine fork just for the alternative translate syntax. This would simplify the UX for interested users.

Not sure about the best ergonomics for the "vanilla" args syntax yet. Would something like "message" + str({ ... }) be good enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the repository, or the CI/CD upstream Depends on an upstream issue or PR, can't be solved immediately version:forked Specific to the Forked version of the extension
Projects
None yet
Development

No branches or pull requests

1 participant