Skip to content

Commit ef1ab30

Browse files
committed
Makefile changes
1 parent dbcb367 commit ef1ab30

File tree

2 files changed

+31
-5
lines changed

2 files changed

+31
-5
lines changed

Makefile

Lines changed: 30 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ GOMOD=$(GOCMD) mod
1010
GOFMT=$(GOCMD) fmt
1111
GODOC=godoc
1212

13-
.PHONY: all test coverage
13+
.PHONY: all test coverage get checkfmt fmt godoc \
14+
examples godoc_examples start-redis stop-redis monitor
15+
1416
all: test coverage examples
1517

1618
get:
@@ -19,7 +21,18 @@ get:
1921
TLS_CERT ?= redis.crt
2022
TLS_KEY ?= redis.key
2123
TLS_CACERT ?= ca.crt
22-
REDISEARCH_TEST_HOST ?= 127.0.0.1:6379
24+
25+
REDIS_SERVER ?= localhost:6379
26+
export REDISEARCH_TEST_HOST=$(REDIS_SERVER)
27+
28+
REDIS_HOST:=$(word 1,$(subst :, ,$(REDIS_SERVER)))
29+
REDIS_PORT:=$(word 2,$(subst :, ,$(REDIS_SERVER)))
30+
ifeq ($(word 1,$(REDIS_HOST)),)
31+
REDIS_HOST:=localhost
32+
endif
33+
ifeq ($(word 1,$(REDIS_PORT)),)
34+
REDIS_PORT:=6379
35+
endif
2336

2437
checkfmt:
2538
@echo 'Checking gofmt';\
@@ -41,16 +54,21 @@ examples: get
4154
./redisearch_tls_client --tls-cert-file $(TLS_CERT) \
4255
--tls-key-file $(TLS_KEY) \
4356
--tls-ca-cert-file $(TLS_CACERT) \
44-
--host $(REDISEARCH_TEST_HOST)
57+
--host $(REDIS_SERVER)
4558

4659
fmt:
4760
$(GOFMT) ./...
4861

4962
godoc_examples: get fmt
5063
$(GOTEST) -race -covermode=atomic ./redisearch
5164

65+
TEST ?= Test
66+
ifeq ($(VERBOSE),1)
67+
TEST_FLAGS += -v
68+
endif
69+
5270
test: get fmt
53-
$(GOTEST) -run "Test" ./redisearch
71+
$(GOTEST) $(TEST_FLAGS) -run $(TEST) ./redisearch
5472

5573
coverage: get
5674
$(GOTEST) -race -coverprofile=coverage.txt -covermode=atomic ./redisearch
@@ -60,3 +78,11 @@ godoc:
6078
echo "Open browser tab on localhost:6060"
6179
$(GODOC)
6280

81+
start-redis:
82+
@docker run --name redisearch-go-tests -d --rm -p 6379:6379 redislabs/redisearch:edge
83+
84+
stop-redis:
85+
@docker stop redisearch-go-tests
86+
87+
monitor:
88+
@redis-cli -h $(REDIS_HOST) -p $(REDIS_PORT) monitor

redisearch/aggregate_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ type Game struct {
3030
Categories []string `json:"categories"`
3131
}
3232

33-
func init() {
33+
func _init() {
3434
/* load test data */
3535
value, exists := os.LookupEnv("REDISEARCH_RDB_LOADED")
3636
requiresDatagen := true

0 commit comments

Comments
 (0)